Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Python PRs don't make use of python changes in CI runs #77479

Open
mqrause opened this issue Oct 31, 2024 · 2 comments
Open

[CI] Python PRs don't make use of python changes in CI runs #77479

mqrause opened this issue Oct 31, 2024 · 2 comments
Labels
(S2 - Confirmed) Bug that's been confirmed to exist

Comments

@mqrause
Copy link
Contributor

mqrause commented Oct 31, 2024

Describe the bug

#77477 fixes an issue with a parser, but Text Changes Analyzer doesn't use the changes and fails with the old error anyway.

Attach save file

n/a

Steps to reproduce

n/a

Expected behavior

Fixed issues are reflected in CI runs.

Screenshots

No response

Versions and configuration

n/a?

Additional context

No response

@mqrause mqrause added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Oct 31, 2024
@Procyonae Procyonae added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Oct 31, 2024
@Uwuewsky
Copy link
Contributor

Uwuewsky commented Nov 1, 2024

I believe CI will be fixed once the PR is merged with the master branch.

@mqrause
Copy link
Contributor Author

mqrause commented Nov 2, 2024

Yes, but the point of this issue is that the PR didn't fix CI within the PR itself. By extension that also means the reverse case would be happening, so you could break CI with a python PR without noticing before it got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

3 participants