Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Mod: Martial Mastery #76278

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

John-Candlebury
Copy link
Member

Summary

Mods "Create the Martial Mastery mod, which allows you to develop your own martial art using a level up system "

Purpose of change

The spell system and related enchantment content currently covers the make your own wizard part of the fantasy RPG trio, but there's very little for players that would like to play warrior or rogue archetypes. This mod seeks to resolve that by letting players build a custom fighting style by selecting different perk locked abilities.

The mod seeks to respect the main game's outlook on the melee combat system. The player imput's for combat will be limited to movement, waiting and attacking, but complex actions can be set up by different rhythms in how these actions are chosen.

Describe the solution

This mod overwrites the default martial art and plugs a wide variety of perks that unlock new techniques and buffs as in bombastic perks, you earn XP by defeating enemies and can level up to unlock new abilities.

This first release focuses on the attack and movement actions, and principally adds techniques for knives, swords and spears. It includes 20+ new perks that have some basic synergies between them.

Describe alternatives you've considered

A larger release but I think this is a good starting point atm.

Testing

A lot of combat.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Melee Melee weapons, tactics, techniques, reach attack Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 8, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Estocada

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Aimless-dude
Copy link
Contributor

If I can make a suggestion, it might be neat if you could learn techniques to use in your custom style by knowing techniques from other fighting styles. Like if you know Boxing, being able to incorporate a Cross Counter into the custom style. If that's, at all possible.

@John-Candlebury
Copy link
Member Author

John-Candlebury commented Sep 8, 2024

No Im not interested in doing that. A lot of specific attacks only make sense in their own martial arts, and I'm seeking to do something more generic.

@ashGlaw
Copy link
Contributor

ashGlaw commented Sep 8, 2024

You have my attention! Very exciting

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 9, 2024
@TheShadowFerret
Copy link
Contributor

Is XP restrictable to melee kills only? "You shoot your way into punching better" doesn't make sense 😛

@John-Candlebury
Copy link
Member Author

Is XP restrictable to melee kills only? "You shoot your way into punching better" doesn't make sense 😛

Unfortunately it isn't.
I think its not overtly terrible because I hope to include upgrades for both bows and crossbows in due time (just as theres a sizeable buff to throwing in one of the perks here)

@Maleclypse Maleclypse merged commit 43dd78a into CleverRaven:master Sep 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Melee Melee weapons, tactics, techniques, reach attack Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants