Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laptop and mp3 player use singular units of batteries rather than actual light/medium/heavy battery #76258

Closed
CoroNaut opened this issue Sep 7, 2024 · 4 comments
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@CoroNaut
Copy link

CoroNaut commented Sep 7, 2024

Describe the bug

Laptop and mp3 player use singular unit batteries for their charge. They can be unloaded into your inventory, but can't actually be placed down on the ground, they just disappear if you try.

Attach save file

TESTING-trimmed.tar.gz

Steps to reproduce

  1. Spawn in laptop or mp3 player or find them
  2. Notice laptop and mp3 charge is in singular units of battery

Expected behavior

Laptop could probably use a medium or heavy battery for default.
The mp3 player probably default to light battery.

At least get rid of the singular batteries to standardize everything to use the light/medium/heavy style.

Screenshots

image
image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4651 (22H2)
  • Game Version: cdda-experimental-2024-09-04-0626 0c909b2 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

No response

@CoroNaut CoroNaut added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Sep 7, 2024
@osuphobia
Copy link
Contributor

I've fixed it in #76167.

@CoroNaut
Copy link
Author

CoroNaut commented Sep 7, 2024

I've update to the latest version. I used debug mode to spawn in a laptop, but i still see it using 200/200 single unit batteries. The first image is a flashlight with a medium battery 'magazine'. The mp3 player and laptop don't have this 'magazine' slot. That PR only makes them unable to be unloaded in their current state. Which also means you can't install an actual light/medium/heavy battery mod into the laptop or mp3 player in this instance, because it can't be unloaded to be able to install the mod. (You can only install the mod once you've fully drained the battery by using them)

The point of my issue was also more specifically the standardization aspect. Having the mp3 player and laptop spawn with a light/medium/heavy battery 'magazine' like the flashlight is what I mean by standardization.

  • OS: Windows
    • OS Version: 10.0.19045.4651 (22H2)
  • Game Version: cdda-experimental-2024-09-07-0110 e398be1 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

image
image
image

@osuphobia
Copy link
Contributor

They were changed to use internal batteries in #76029

@CoroNaut
Copy link
Author

CoroNaut commented Sep 7, 2024

Alright, I didn't realize we moved to this default rather than have a standardized battery system.

@CoroNaut CoroNaut closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

2 participants