Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImGui: AIM examine panel wrong offset #75756

Closed
alef opened this issue Aug 17, 2024 · 10 comments
Closed

ImGui: AIM examine panel wrong offset #75756

alef opened this issue Aug 17, 2024 · 10 comments
Labels
ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds Info / User Interface Game - player communication, menus, etc. (S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@alef
Copy link
Contributor

alef commented Aug 17, 2024

Describe the bug

See the screenshot.

Attach save file

N/A

Steps to reproduce

  1. Open AIM /
  2. examine a worn item in >W< slot
  3. menu pane shows in wrong position

Expected behavior

The pane should be attached to the examine report.

Screenshots

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4651 (22H2)
  • Game Version: 0b8d7ba-dirty [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

Related to #74341 .
Probably for @db48x

@alef alef added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Aug 17, 2024
@db48x
Copy link
Contributor

db48x commented Aug 17, 2024

Nice. Looks like it’s calculating the position using the wrong font metrics. Thanks for filing it!

@db48x
Copy link
Contributor

db48x commented Aug 17, 2024

Incidentally, there is another window that is offset in a similar way. Can you go examine something that is attached to a power grid and see if that is offset correctly or not? If you don’t have a power grid handy, just look for a microwave or a standing lamp or something and examine it.

@alef
Copy link
Contributor Author

alef commented Aug 17, 2024

image

@db48x
Copy link
Contributor

db48x commented Aug 18, 2024

Yep, same problem.

@Karol1223 Karol1223 added Info / User Interface Game - player communication, menus, etc. ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds labels Aug 19, 2024
@alef
Copy link
Contributor Author

alef commented Aug 26, 2024

Both are fixed, thank you!

@alef alef closed this as completed Aug 26, 2024
@db48x
Copy link
Contributor

db48x commented Aug 26, 2024

Are you sure this is fixed? I don’t see any code changes that would fix it…

@alef
Copy link
Contributor Author

alef commented Aug 26, 2024

911eeed47
image
image

@db48x
Copy link
Contributor

db48x commented Aug 26, 2024

Those have dramatically different fonts than before.

@alef
Copy link
Contributor Author

alef commented Aug 26, 2024

Fonts are different because of #75920 and #75937

@db48x
Copy link
Contributor

db48x commented Aug 26, 2024

Oh, nice! Thanks for fixing that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds Info / User Interface Game - player communication, menus, etc. (S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

3 participants