Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nerf the warmth values of some undergarments and thin clothes. #74189

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

Aerin-of-the-Toast
Copy link
Contributor

Summary

Balance "Lower the warmth values of some undergarments and thin clothes."

Purpose of change

Staying warm even in the dead of winter without any cold-weather clothing is really easy right now, largely due to a few outlier clothing, usually undergarments that are extremely thin, very low-encumbrance, high warmth, and in the least-competitive "close-to-skin" category. This makes actual proper cold weather gear undesirable if you can replace a thick jacket with some long johns that don't interfere with your armor, are less encumbering, and somehow are warmer despite being thin cotton.

Describe the solution

Nerf the warmth values of the long underwear bottoms, long underwear tops, and union suits to 10 down from 30 (35 for the union suit). Nerf the light gloves to 10 warmth, down from 20. Nerf glove liners to 5 warmth down from 15. Nerf the undershirt to 5 from 10 warmth. For all this cotton clothing, I generally just made it so that 0.1mm of cotton was 5 warmth and 0.2mm of cotton was 10. This means they can help take the edge off if it's a little nippy but you can't replace your winter coat just by wearing two sets of long johns to survive in sub-zero temperatures mid-winter.

"Nerfed" the compression top/shorts to 4 warmth from 20. This actually gives them their proper niche as warm-weather undergarments to help keep you cool due to the moisture-wicking, which previously was pointless when they were warmer than jackets or thick pants and would make you overheat. Also, from experience, they really don't do much for cold at all.

Describe alternatives you've considered

There's almost certainly clothes I missed; debated touching on stuff like the arm or leg warmers or the thermal shirt but either wasn't sure if they're that warm or not, or just figured they weren't as egregious. I don't have experience with them.

Alternatively, make a massive overhaul that automatically fills in warmth based on material and thickness similar to armor (I'm not doing this).

Testing

Game works, fingies are properly chilly.

Additional context

weh

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 30, 2024
@XygenSS
Copy link
Contributor

XygenSS commented May 30, 2024

It could be argued that undergarments provide extra warmth than they appear to because of insulation benefits from layering your clothes.

But I guess a better approach would be to actually implement a layering warmth bonus.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 30, 2024
@Maleclypse
Copy link
Member

Leather gloves aren't very warm in the winter either. Do they already have a low warmth value or should you audit them while here?

@Aerin-of-the-Toast
Copy link
Contributor Author

Leather gloves aren't very warm in the winter either. Do they already have a low warmth value or should you audit them while here?

25 for 0.5mm of leather. I mostly didn't touch them since I've never tried wearing leather gloves in winter, so I've no idea if that's accurate or not. They're also less egregious in terms of the warmth:encumbrance (25:5) compared to light gloves (20:1) so I wasn't really looking at them.

@Maleclypse
Copy link
Member

Leather gloves aren't very warm in the winter either. Do they already have a low warmth value or should you audit them while here?

25 for 0.5mm of leather. I mostly didn't touch them since I've never tried wearing leather gloves in winter, so I've no idea if that's accurate or not. They're also less egregious in terms of the warmth:encumbrance (25:5) compared to light gloves (20:1) so I wasn't really looking at them.

Fair, I just know when I lived in Mass my leather gloves were for fall and early winter, once the snows come you needed heavier stuff. :)

@Hyperseeker
Copy link
Contributor

I feel like dress shirt with its warmth of 10 might be a good fit for this PR, as well.

@Aerin-of-the-Toast
Copy link
Contributor Author

Aerin-of-the-Toast commented May 31, 2024

I feel like dress shirt with its warmth of 10 might be a good fit for this PR, as well.

Not convinced it's inaccurate (I'm not trying to make 0.1mm cotton being 5 warmth a law and dress shirts a bit stuffier than t-shirts) and even if it was it's hardly egregious IMO. Also I'm too lazy.

@dseguin dseguin merged commit 055550c into CleverRaven:master Jun 1, 2024
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants