Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add combat exoskeleton template to aftershock nanofab #73475

Conversation

KamikazieBoater
Copy link
Contributor

@KamikazieBoater KamikazieBoater commented May 3, 2024

Summary

Bugfixes "Add Combat Exoskeleton template to Aftershock Nanofabricator"

Purpose of change

Allow the new combat exoskeleton nanofabricator templates to be used with nanofabricators when running the Aftershock mod.

Describe the solution

Aftershock overwrites the standard nanofabricator control panel to allow for the use of the mods Wraitheon production chips. The overwrite needs to be updated to allow for the use of the recently added combat exoskeleton templates added by #68758

Describe alternatives you've considered

Ideally there would be a way for Aftershock to extend the existing definition of the nanofabricator control panel terrain's allowed template ids rather than overwrite, but I'm not aware of an existing means for doing so.

Testing

Added the id for the combat exoskeleton template to the list of allowed nanofabricator templates in aftershock, loaded game, and was able to produce combat exoskeleton parts at a nanofabricator as expected.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Aftershock Anything to do with the Aftershock mod labels May 3, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 3, 2024
@John-Candlebury
Copy link
Member

I dont oppose to the concept, but those are vanilla combat exoskeletons and their modules. You should make a new template and list that uses the aftershock versions.

@KamikazieBoater
Copy link
Contributor Author

I dont oppose to the concept, but those are vanilla combat exoskeletons and their modules. You should make a new template and list that uses the aftershock versions.

I'll put together a separate PR for Aftershock enhancements to add a relevant template for the Aftershock combat exoskeleton variants, along with adding appropriate references and updating associated loot lists. If that gets done before this is merged to main, I'll close this PR since the new scope will encompass this fix.

…ctured.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 4, 2024
@John-Candlebury John-Candlebury merged commit d6a507f into CleverRaven:master May 6, 2024
23 of 24 checks passed
@John-Candlebury
Copy link
Member

Failed to originally grasp that this was a valid bugfix when playing without the exoplanet mod. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants