-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sends the Spas-12 into retirement, Mossbergs divorce, and Benellis invade #72398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… actualy longer. does this, about 2 seconds before hitting go on the PR.
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Spawn
Creatures, items, vehicles, locations appearing on map
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
Mods: Generic Guns
Anything to do with Generic Guns
Items: Armor / Clothing
Armor and clothing
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Mar 14, 2024
I halp! |
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Mar 15, 2024
Thank you! Please keep the weapon updates coming! :) |
This was referenced Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
Items: Armor / Clothing
Armor and clothing
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Generic Guns
Anything to do with Generic Guns
Mods
Issues related to mods or modding
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Adds three new Benelli semi-automatic shotguns, splits the Mossberg 500 Field and 500 Security, and retires the Spas-12."
Purpose of change
As I previously discussed in PR #71575, there are some guns in CDDA that, while very cool, are far too rare in the real world to ever be found within the environment the game simulates. These are weapons that, whether being foreign service rifles, banned destructive devices, or one of a number of other categories of guns, fell into the status of highly rare pieces that would, at best, come up once in a while during a several hundred-hour playthrough after having already played the game for several years. Last time, the patient slated for invasive surgery was the AK-74M assault rifle, and this round, it’s the Spas-12’s turn to go under the knife.
Apart from the crusade against aberrant guns, issue #71233 pointed out that the Mossberg 500 Field and Security models of shotgun have identical stats, despite the former being described as possessing a 28-inch long barrel and the latter being an 18.5-inch configuration. This was due to both weapons being made variants of one another: fundamentally the same gun under the hood with a name and description change.
Lastly, I don’t enjoy removing something from the game without putting something back in. I happen to like Benellis. We happen to have one Benelli: the M1014. One plus one equals action had to urgently be taken to preserve the karmic balance of the CDDA gun world.
Describe the solution
In order, as previously discussed, in this PR, I have:
Describe alternatives you've considered
I considered:
Testing
I loaded a local build of the game with the changes implemented and punched my way into several gun and hunting stores, literally, and observed that the new guns spawned correctly. I picked up said guns and committed factory disassembly upon various zombies with no issues. I tried to spawn in a Spas through the debug menu with no results.
Additional context
Thanks to @tenmillimaster for working up a shortlist of includable Benelli guns that make it past the amount requirement.