Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy 16 fails in CI #68325

Closed
harakka opened this issue Sep 25, 2023 · 1 comment · Fixed by #68331
Closed

clang-tidy 16 fails in CI #68325

harakka opened this issue Sep 25, 2023 · 1 comment · Fixed by #68331
Labels
(S2 - Confirmed) Bug that's been confirmed to exist

Comments

@harakka
Copy link
Member

harakka commented Sep 25, 2023

Describe the bug

clang-tidy 16 fails in every CI run because FindSDL2_mixer.cmake can't find the flac dependency. This is probably caused by #68300 as it modified the tooling and tests started failing after it was merged.

Relevant error from an example full example here

-- Found SDL2_mixer: /usr/lib/x86_64-linux-gnu/libSDL2_mixer.so  
-- Searching for SDL_mixer deps libraries --
-- Checking for module 'flac'
--   No package 'flac' found
CMake Error at /usr/local/share/cmake-3.27/Modules/FindPkgConfig.cmake:607 (message):
  A required package was not found
Call Stack (most recent call first):
  /usr/local/share/cmake-3.27/Modules/FindPkgConfig.cmake:829 (_pkg_check_modules_internal)
  CMakeModules/Find/FindSDL2_mixer.cmake:115 (pkg_check_modules)
  CMakeLists.txt:334 (find_package)


-- Configuring incomplete, errors occurred!
Error: Process completed with exit code 1.

Attach save file

N/A

Steps to reproduce

Have a commit in a PR that triggers clang-tidy 16 run

Expected behavior

clang-tidy 16 setup to run successfully

Screenshots

No response

Versions and configuration

N/A

Additional context

No response

@harakka harakka added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Sep 25, 2023
@harakka
Copy link
Member Author

harakka commented Sep 25, 2023

/confirm

@github-actions github-actions bot added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant