Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crafting GUI -> filter issues #64626

Closed
Brambor opened this issue Mar 28, 2023 · 1 comment
Closed

Crafting GUI -> filter issues #64626

Brambor opened this issue Mar 28, 2023 · 1 comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.

Comments

@Brambor
Copy link
Contributor

Brambor commented Mar 28, 2023

Describe the bug

Assuming #64627 will get merged which introduces this issue in English. Edit: The issue was fixed for English in #77916.
However, it probably was there already in other languages

crafting gui -> filter doesn't wrap nicely.
image

Attach save file

N/A

Steps to reproduce

Wierd Wrap:

  1. rebase on PR Crafting GUI filters m: (don't show nested) r: (added - filter by (by)product) #64627 / have too much text (width-wise) in crafting_gui>filter
  2. open crafting GUI
  3. press f to filter
  4. observe that the text is not wrapped aesthetically
    image

PageUp/PageDown not working:

  1. rebase on PR Crafting GUI filters m: (don't show nested) r: (added - filter by (by)product) #64627 / have too much text (height-wise) in crafting_gui>filter window so you can get scrollbar in step (3)
  2. open crafting GUI
  3. press f to filter
  4. make the window bigger until there isn't a scrollbar, if there is one
  5. make the window smaller until there is a scrollbar
    image
  6. You cannot use PageUp / PageDown anymore to scroll.
  7. You still can use a mouse click/wheel to scroll.

Expected behaviour

Pretty wrap.

Always be able to scroll with the keyboard.

Screenshots

No response

Versions and configuration

Not on master!

  • OS: Windows
    • OS Version: 10.0.19044.2728 (21H2)
  • Game Version: 0.G-909-g8eebe0faf4 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]

Additional context

No response

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 27, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.
Projects
None yet
Development

No branches or pull requests

1 participant