Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR: why we only use the disabled attribute in very specific cases (as little as possible) #1298

Open
florian-sanders-cc opened this issue Jan 14, 2025 · 0 comments
Assignees
Labels
docs Related to documentation

Comments

@florian-sanders-cc
Copy link
Contributor

Context

The disabled attribute has cause many issues related to focus management.

They are fairly complex and they led us to take very opinionated decisions + conventions:

  • use readonly instead of disabled during API calls for form controls (except buttons),
  • for cc-button, use waiting instead of disabled (and forbid using both at the same time) during API calls.

Reasons for these changes are tracked within issues which contain fairly detailed explanations but it's not very convenient for new contributors or even for us.
We should write an ADR to sum up our decisions + why we made these choice.
We should also probably update the contributing guidelines to add a section about what to do with buttons & form controls during API calls (+ link to the ADR to explain why).

@florian-sanders-cc florian-sanders-cc self-assigned this Jan 14, 2025
@florian-sanders-cc florian-sanders-cc added the docs Related to documentation label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to documentation
Projects
None yet
Development

No branches or pull requests

1 participant