Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc-zone: center content vertically when there is no tag #1225

Open
florian-sanders-cc opened this issue Oct 30, 2024 · 1 comment
Open

cc-zone: center content vertically when there is no tag #1225

florian-sanders-cc opened this issue Oct 30, 2024 · 1 comment
Assignees
@florian-sanders-cc
Labels
bug Something isn't working

Comments

@florian-sanders-cc
Copy link
Contributor

Context

When there is no tag, the cc-zone component alignment is not optimal:
image

It would be better to center the content vertically.

To do so, we would need to add a wrapper instead of using display: flex on the :host because we would need to use a classMap to toggle a class when there are no tags (tags are part of the state property so we cannot rely on a reflected attribute like we do for modes).

This is probably a breaking change.
@florian-sanders-cc florian-sanders-cc self-assigned this Oct 30, 2024
@florian-sanders-cc florian-sanders-cc added breaking-change Something that will required a major semver release bug Something isn't working easy-quick-win labels Oct 30, 2024
@florian-sanders-cc florian-sanders-cc removed the breaking-change Something that will required a major semver release label Nov 27, 2024
@florian-sanders-cc
Copy link
Contributor Author

Not really a quick win, it's tricky and annoying 😹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florian-sanders-cc florian-sanders-cc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@florian-sanders-cc