Upd. Settings. Improved scan tab render. #444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandergull
requested changes
Nov 25, 2024
| @@ -1953,6 +1956,15 @@ function spbc_scanner_get_file_by_id($file_id) | |||
| return $file_info ?: false; | |||
| } | |||
|
|
|||
| function spbc_scanner_load_more_scan_logs() | |||
There was a problem hiding this comment.
Please, add doc-block and rerun tests.
| @@ -1108,19 +1109,21 @@ function spbc_get_sql_where_addiction_for_table_of_category($category) | |||
| * @param string $category Category of files category which needs to be searched for | |||
| * @return array Array of IDs | |||
| */ | |||
| function spbc_scanner_get_files_by_category($category) | |||
| function spbc_scanner_get_files_by_category($category, $count = false) | |||
There was a problem hiding this comment.
Please, update doc-block with new param and rerun tests
| // suppress because data is static | ||
| // @psalm-suppress WpdbUnsafeMethodsIssue | ||
| $res = $wpdb->get_results($query); | ||
|
|
||
| foreach ($res as $tmp) { | ||
| $ids[] = $tmp->fast_hash; | ||
| $ids[] = isset($tmp->fast_hash) ? $tmp->fast_hash : null; |
alexandergull
requested review from
AntonV1211
and removed request for
Glomberg
AntonV1211
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task https://doboard.com/1/task/10014