Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompilation error for changes made to EOSmodel.jl #307

Open
branch171 opened this issue Nov 12, 2024 · 5 comments
Open

precompilation error for changes made to EOSmodel.jl #307

branch171 opened this issue Nov 12, 2024 · 5 comments

Comments

@branch171
Copy link

branch171 commented Nov 12, 2024

Clapeyron will note cleanly precompile:

To solve the problem replace with commented code with the one below in EoSmodel.jl

#function eos_impl(model,V,T,z)
#    return Rgas(model)*sum(z)*T*a_eos(model,V,T,z) + reference_state_eval(model,V,T,z)
#end

function eos_impl(model::EoSModel, V, T, z=SA[1.0])
    return Rgas(model)*sum(z)*T*a_eos(model,V,T,z) + reference_state_eval(model,V,T,z)
end
@longemen3000
Copy link
Member

ohhh, good one!

@branch171
Copy link
Author

branch171 commented Nov 12, 2024

Note sure why but its only fixed with:

function eos(model::EoSModel, V, T, z = SA[1.0])
     return Rgas(model)*sum(z)*T*a_eos(model,V,T,z) + reference_state_eval(model,V,T,z)
end

@branch171
Copy link
Author

Yes sorry, I thought I had fixed this. It does run clean with only Clapeyron but as soon as you add another package that using Symbolics it tries to precompile Clapeyron → ClapeyronSymbolicsExt and fails. However, things seem to work its just irritating to not have a clean output.

@longemen3000
Copy link
Member

yeah, it is bothering me too, but i can't getting it fixed, any help is really appreciated

@longemen3000
Copy link
Member

longemen3000 commented Nov 12, 2024

i opened an issue in the Symbolics.jl repository (JuliaSymbolics/Symbolics.jl#1358), along with a MWE. (cc @Sush1090 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants