Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timeline #36

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

fix timeline #36

wants to merge 1 commit into from

Conversation

Kistine
Copy link
Contributor

@Kistine Kistine commented Aug 21, 2018

Simplified value statement and removed basefilter so chart would load

Simplified value statement and removed basefilter so chart would load
@Kistine
Copy link
Contributor Author

Kistine commented Aug 21, 2018

@timwis - for when you're back, would like your review that it's ok to remove the basefilter. timeline chart wouldn't load with it included, but want to make sure it's not necessary before pushing live.

@Kistine Kistine self-assigned this Aug 21, 2018
@Kistine Kistine requested a review from timwis August 21, 2018 18:33
@timwis
Copy link
Contributor

timwis commented Sep 27, 2018

Is this working for you when you preview it on your computer? It looks like the to_date() function was in there previously, which suggests the field type in the database was a string rather than a date. The only way that wouldn't be necessary now, I imagine, is if the field type was changed (which would have required @Alexander-M-Waldman to change the schema file for the carto sync to work). But yes if it's working for you locally then I'd say good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants