Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOR addresses are being QC'd before being parsed #121

Open
bertday opened this issue Apr 25, 2017 · 0 comments
Open

DOR addresses are being QC'd before being parsed #121

bertday opened this issue Apr 25, 2017 · 0 comments

Comments

@bertday
Copy link
Contributor

bertday commented Apr 25, 2017

In load_dor_parcels it looks like the addresses components of each parcel are being tested before being run through Passyunk. If they don't meet certain criteria (e.g. "known street name"), they get excluded from the build. As a result, all parcels on MC CLELLAN ST, which gets standardized to MCCLELLAN ST by Passyunk are being filtered out.

IIRC the reason for this was to flag them as errors in the dor_parcel_error table. We may need to change the logic in load_dor_parcels to write out a warning instead so these parcels can still participate.

FYI @Alexander-M-Waldman I don't think this is new behavior (i.e. it's probably been like this forever) but just wanted to make sure it was documented :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant