Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merit class UncertaintyCorrelation yields nan for constant predictive uncertainties #193

Open
mrupp-citrine opened this issue Aug 29, 2019 · 0 comments

Comments

@mrupp-citrine
Copy link
Contributor

When calling UncertaintyCorrelation with predictive distributions that have constant uncertainty, value varSigma (line 131 in Merit.scala) is zero, leading to denominator being zero. As the numerator is also zero, not-a-number (nan) is returned.

This behaviour seems undesirable. I suggest throwing an exception to signal the problem instead of silently inserting nan into calculations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant