Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ASA regex #841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated ASA regex #841

wants to merge 1 commit into from

Conversation

kingfetty
Copy link

Description

Updated regex for ASA 'show failover' and 'show version' commands.

Motivation and Context

Previous regex did not handle interfaces with names starting with "Ethernet".
Previous regex did not handle processor types with '/' in the output.

Impact (If any)

None

Screenshots:

pyats test pass

Checklist:

  • I have updated the changelog.
  • I have updated the documentation (If applicable).
  • I have added tests to cover my changes (If applicable).
  • All new and existing tests passed.
  • All new code passed compilation.

@kingfetty kingfetty requested a review from a team as a code owner April 11, 2024 15:43
@kingfetty
Copy link
Author

any movement here on code review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasJRyan ThomasJRyan Awaiting requested review from ThomasJRyan ThomasJRyan is a code owner automatically assigned from CiscoTestAutomation/pyats-genie-devs

@Taarini Taarini Awaiting requested review from Taarini Taarini is a code owner automatically assigned from CiscoTestAutomation/pyats-genie-devs

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kingfetty