Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ndo_l3out_node_group_policy module to manage L3Out Node Group Policy (DCNE-181) #555

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Added ndo_l3out_node_group_policy module to manage L3Out Node Group Policy (DCNE-181) #555

wants to merge 12 commits into from
+1,280 −9

Conversation

sajagana
Copy link
Collaborator

No description provided.

@sajagana sajagana linked an issue Oct 22, 2024 that may be closed by this pull request
Enhancement: New module for NDO L3Out Node Group Policy (DCNE-181) #534
Open
@github-actions github-actions bot changed the title Added ndo_l3out_node_group_policy module to manage L3Out Node/Interface Group Policy Added ndo_l3out_node_group_policy module to manage L3Out Node/Interface Group Policy (DCNE-181) Oct 22, 2024
@sajagana sajagana force-pushed the 534_l3out_node_group_policy branch from e5e4e0e to 3aacd20 Compare October 22, 2024 16:03
akinross
akinross requested changes Oct 23, 2024
View reviewed changes
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
@sajagana sajagana force-pushed the 534_l3out_node_group_policy branch from 5e83034 to 68b3b6e Compare October 23, 2024 18:53
@sajagana sajagana requested a review from akinross October 24, 2024 02:39
samiib
samiib requested changes Oct 24, 2024
View reviewed changes
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
@sajagana sajagana requested a review from samiib October 24, 2024 05:02
akinross
akinross requested changes Oct 24, 2024
View reviewed changes
plugins/module_utils/template.py Outdated Show resolved Hide resolved
plugins/module_utils/template.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
@sajagana sajagana requested a review from akinross October 24, 2024 13:11
@sajagana sajagana force-pushed the 534_l3out_node_group_policy branch from 985a395 to ce3f91f Compare October 24, 2024 13:33
@sajagana sajagana changed the title Added ndo_l3out_node_group_policy module to manage L3Out Node/Interface Group Policy (DCNE-181) Added ndo_l3out_node_group_policy module to manage L3Out Node Group Policy (DCNE-181) Oct 25, 2024
@sajagana sajagana force-pushed the 534_l3out_node_group_policy branch from ef98298 to b0321c7 Compare October 30, 2024 09:28
@sajagana sajagana requested a review from akinross October 30, 2024 09:32
@sajagana sajagana force-pushed the 534_l3out_node_group_policy branch from b0321c7 to 9f8028f Compare October 31, 2024 00:53
akinross
akinross requested changes Nov 6, 2024
View reviewed changes
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_node_group_policy.py Outdated Show resolved Hide resolved
@sajagana sajagana force-pushed the 534_l3out_node_group_policy branch from 9e01cdf to cb02685 Compare November 6, 2024 12:29
@sajagana sajagana requested a review from akinross November 6, 2024 12:31
@samiib samiib self-requested a review November 12, 2024 00:20
samiib
samiib previously approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajagana sajagana dismissed stale reviews from samiib, akinross, and shrsr via 2096029 December 17, 2024 06:41
akinross
akinross previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr
Copy link
Collaborator

shrsr commented Dec 17, 2024

Rebase is required

@sajagana
[minor_change] Added ndo_l3out_node_group_policy module to manage L3O…
f7287e8 
…ut Node/Interface Group Policy
@sajagana
[minor_change] Fixed the bfd_multi_hop_authentication attribute value…
818ad62 
… set logic in the ndo_l3out_node_group_policy module
@sajagana
[minor_change] Fixed ndo_l3out_node_group_policy module doc
bd850a2
@sajagana
[ignore] Fixed the update logic to clear bfd config on ndo_l3out_node…
3b3a5bd 
…_group_policy module
@sajagana
[ignore] Changed the bfd multi-hop attribute structure in ndo_l3out_n…
5affc77 
…ode_group_policy module
@sajagana
[ignore] Removed state from ndo_l3out_node_group_policy module attribute
d89dff2
@sajagana
[ignore] Added name check to the query all assertion task
6a30317
@sajagana
[ignore] Rebased with latest master to include append_update_ops_data…
fe8e1d3 
… for the ndo_l3out_node_group_policy module
@sajagana
[ignore] Removed ENABLED_DISABLED_BOOLEAN_MAP from constants.py file
41e7e98
@sajagana
[ignore] Removed UUID from get_l3out_node_group function doc string f…
93a5fdb 
…rom the mso_utils template.py
@sajagana
[ignore] Changed the BFD Multi Hop create and update logic
71e9808
@sajagana
[ignore] Added seealso section to the ndo_l3out_node_group_policy module
e1eecfd
@sajagana sajagana dismissed stale reviews from shrsr, samiib, and akinross via e1eecfd December 17, 2024 15:07
@sajagana sajagana force-pushed the 534_l3out_node_group_policy branch from 2096029 to e1eecfd Compare December 17, 2024 15:07
@shrsr shrsr self-requested a review December 17, 2024 18:26
shrsr
shrsr approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrsr shrsr shrsr approved these changes

@samiib samiib samiib left review comments

@akinross akinross akinross left review comments

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

@gmicol gmicol Awaiting requested review from gmicol gmicol is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: New module for NDO L3Out Node Group Policy (DCNE-181)
5 participants
@sajagana @shrsr @akinross @samiib @gmicol