[minor_changes] Adding new module for physical interface (DCNE-50) #560
+906
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvitha-jain
requested review from
lhercot,
shrsr,
akinross,
sajagana,
samiib and
gmicol
anvitha-jain
force-pushed
the
physical_interface
branch
from
d67d034 to
e253d7b
Compare
anvitha-jain
added
enhancement
github-actions
bot
changed the title
|
sanity fails |
samiib
requested changes
Nov 6, 2024
tests/integration/targets/ndo_physical_interface/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/ndo_physical_interface/tasks/main.yml
Outdated
Show resolved
Hide resolved
|
The sanity fails because of a function which doesn't exist, since this function is being added in another PR #539 |
shrsr
requested changes
Nov 8, 2024
anvitha-jain
force-pushed
the
physical_interface
branch
2 times, most recently
from
54cabb7 to
a710854
Compare
shrsr
requested changes
Nov 13, 2024
anvitha-jain
force-pushed
the
physical_interface
branch
from
a710854 to
3e83428
Compare
akinross
requested changes
Nov 14, 2024
anvitha-jain
force-pushed
the
physical_interface
branch
from
3e83428 to
19e105d
Compare
shrsr
requested changes
Nov 19, 2024
anvitha-jain
force-pushed
the
physical_interface
branch
from
19e105d to
fb6abdf
Compare
samiib
reviewed
Nov 23, 2024
tests/integration/targets/ndo_physical_interface/tasks/main.yml
Outdated
Show resolved
Hide resolved
anvitha-jain
force-pushed
the
physical_interface
branch
from
fb6abdf to
09f6a13
Compare
anvitha-jain
force-pushed
the
physical_interface
branch
from
09f6a13 to
f185d34
Compare
shrsr
requested changes
Dec 10, 2024
|
|
||
| if mso.existing: | ||
| proposed_payload = copy.deepcopy(match.details) | ||
|
|
There was a problem hiding this comment.
Can we leverage the new function append_update_ops_data() here?
sajagana
requested changes
Dec 12, 2024
plugins/module_utils/mso.py
Outdated
| @@ -318,6 +318,19 @@ def write_file(module, url, dest, content, resp, tmpsrc=None): | |||
| os.remove(tmpsrc) | |||
|
|
|||
|
|
|||
| def format_interface_descriptions(interface_descriptions, node=None): | |||
| formated_interface_descriptions = [ | |||
There was a problem hiding this comment.
Suggested change
| formated_interface_descriptions = [ | |
| formatted_interface_descriptions = [ |
plugins/module_utils/mso.py
Outdated
| for interface_description in interface_descriptions | ||
| ] | ||
|
|
||
| return formated_interface_descriptions |
There was a problem hiding this comment.
Suggested change
| return formated_interface_descriptions | |
| return formatted_interface_descriptions |
Comment on lines
360
to
365
| payload = { | ||
| "name": name, | ||
| "nodes": nodes, | ||
| "interfaces": interfaces, | ||
| "policyGroupType": physical_interface_type, | ||
| } |
There was a problem hiding this comment.
Suggested change
| payload = { | |
| "name": name, | |
| "nodes": nodes, | |
| "interfaces": interfaces, | |
| "policyGroupType": physical_interface_type, | |
| } | |
| mso_values = dict( | |
| name = name, | |
| nodes = nodes, | |
| interfaces = interfaces, | |
| policyGroupType = physical_interface_type, | |
| ) |
Our team planned to maintain the variable naming consistency for the new modules.
sajagana
requested changes
Dec 16, 2024
|
|
||
| update_path = "{0}/{1}".format(path, match.index) | ||
|
|
||
| if interface_descriptions == [] and proposed_payload.get("interfaceDescriptions"): |
There was a problem hiding this comment.
Please add a documentation note to explain the update and clear processes of the "interface_descriptions".
| - nm_delete_physical_interface_again.previous == nm_delete_physical_interface_again.current == {} | ||
| - nm_delete_physical_interface_again.current.uuid is not defined | ||
|
|
||
| - name: Query all tests |
There was a problem hiding this comment.
Do you need this task? Change the task name.
| - name: Update Physical Interface of type 'breakout' by removing interface interface_descriptions | ||
| cisco.mso.ndo_physical_interface: | ||
| <<: *update_physical_interface_uuid | ||
| interface_descriptions: [] |
There was a problem hiding this comment.
Could you add a task to update interface_descriptions values before completely clearing it?
Could you add an element with an existing value and remove it?
akinross
requested changes
Dec 16, 2024
| check_mode: true | ||
| register: cm_physical_interface | ||
|
|
||
| - name: Create Physical Interface of type 'physical' |
There was a problem hiding this comment.
CI appears broken, there are dangling objects for this policy without a template. This makes the testing fail.
akinross
reviewed
Dec 16, 2024
Comment on lines
+30
to
+31
| - name: Execute tasks only for MSO version > 4.3 | ||
| when: version.current.version is version('4.3', '>=') |
There was a problem hiding this comment.
this should be 4.4 I think, because now CI does not work
There was a problem hiding this comment.
we should add a 4.4 instance to CI for testing this func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(object: interfaceProfiles)
solves #392
it required ndo_interface_seeting module #540