Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Button to Open Circuit Link in Browser #271

Closed
wants to merge 4 commits into from
Closed

added Button to Open Circuit Link in Browser #271

wants to merge 4 commits into from

Conversation

sainideepanshu199
Copy link

Fixes #261

Describe the changes you have made in this PR -
added button that opens the circuit link in device default browser

Screenshots of the changes (If any) -

Screenshot_20230227-234119 1
Screenshot_20230227-234116 1

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

tanmoysrt
tanmoysrt reviewed Feb 28, 2023
View reviewed changes
lib/ui/views/projects/project_details_view.dart Outdated
Comment on lines 73 to 76
onPressed: () async {
final url = Uri.parse(
'https://circuitverse.org/users/${widget.project.relationships.author.data.id}/projects/${widget.project.id}');
await launchUrl(url, mode: LaunchMode.externalApplication);
Copy link
Member

@tanmoysrt tanmoysrt Feb 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already an predefined function for launchUrl in lib/utils/url_launcher.dart, kindly use that function to open the link and do require changes if required.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have changed the code accordingly , please review the code.

@tanmoysrt
Copy link
Member

@vedant-jain03 it's ready to be merged

vedant-jain03
vedant-jain03 approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@vedant-jain03 vedant-jain03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @aman-singh7 @manjotsidhu

@manjotsidhu
Copy link
Member

@Tanmoy741127 @sainideepanshu199 Here as well launchURL function could be used in alot of places, we should not be causing effects in other parts of the apps.

@tanmoysrt
Copy link
Member

@Tanmoy741127 @sainideepanshu199 Here as well launchURL function could be used in alot of places, we should not be causing effects in other parts of the apps.

ok !

tanmoysrt
tanmoysrt suggested changes Mar 4, 2023
View reviewed changes
lib/utils/url_launcher.dart
await launchUrlString(url);
await launchUrlString(url, mode: LaunchMode.externalApplication);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default , keep it launchUrlString(url) without mode: LaunchMode.externalApplication

Pass an varibale in function openInExternalApplication with default value False

Do the necessary changes, in the mode: LaunchMode.externalApplication also.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4329758659

  • 4 of 8 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 64.621%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/utils/url_launcher.dart 0 1 0.0%
lib/ui/views/projects/project_details_view.dart 4 7 57.14%
Totals Coverage Status
Change from base Build 3668186862: -0.008%
Covered Lines: 4044
Relevant Lines: 6258
💛 - Coveralls

@sainideepanshu199
Copy link
Author

i am getting errors in some files , can anyone tell why is this error
image

@tanmoysrt
Copy link
Member

tanmoysrt commented Mar 5, 2023 •
edited
Loading

i am getting errors in some files , can anyone tell why is this error image

The issue due to some unresolved third party package import maybe. Run flutter pub get and check whether the issue got fixed.

@sainideepanshu199
Copy link
Author

i am getting errors in some files , can anyone tell why is this error image

The issue due to some unresolved third party package import maybe. Run flutter pub get and check whether the issue got fixed.

no even after running flutter pub get , i am getting same issue

@tanmoysrt
Copy link
Member

i am getting errors in some files , can anyone tell why is this error image

The issue due to some unresolved third party package import maybe. Run flutter pub get and check whether the issue got fixed.

no even after running flutter pub get , i am getting same issue

Can you hover on the issue and check whether it's a import issue or deprecation warning

@sainideepanshu199
Copy link
Author

i am getting errors in some files , can anyone tell why is this error image

The issue due to some unresolved third party package import maybe. Run flutter pub get and check whether the issue got fixed.

no even after running flutter pub get , i am getting same issue

Can you hover on the issue and check whether it's a import issue or deprecation warning

mostly errors are due to argument cannot be assigned to parameter

@tanmoysrt
Copy link
Member

i am getting errors in some files , can anyone tell why is this error image

The issue due to some unresolved third party package import maybe. Run flutter pub get and check whether the issue got fixed.

no even after running flutter pub get , i am getting same issue

Can you hover on the issue and check whether it's a import issue or deprecation warning

mostly errors are due to argument cannot be assigned to parameter

Ok I will check

@sainideepanshu199
Copy link
Author

i am getting errors in some files , can anyone tell why is this error image

The issue due to some unresolved third party package import maybe. Run flutter pub get and check whether the issue got fixed.

no even after running flutter pub get , i am getting same issue

Can you hover on the issue and check whether it's a import issue or deprecation warning

mostly errors are due to argument cannot be assigned to parameter

Ok I will check

is their any update on these errors as i am still getting these errors and it's giving problem in the build and development of app. please tell if i am the only one facing the problem.

@tanmoysrt
Copy link
Member

i am getting errors in some files , can anyone tell why is this error image

The issue due to some unresolved third party package import maybe. Run flutter pub get and check whether the issue got fixed.

no even after running flutter pub get , i am getting same issue

Can you hover on the issue and check whether it's a import issue or deprecation warning

mostly errors are due to argument cannot be assigned to parameter

Ok I will check

is their any update on these errors as i am still getting these errors and it's giving problem in the build and development of app. please tell if i am the only one facing the problem.

I haven't got time to check, will trying to check today

@tanmoysrt
Copy link
Member

i am getting errors in some files , can anyone tell why is this error image

The issue due to some unresolved third party package import maybe. Run flutter pub get and check whether the issue got fixed.

no even after running flutter pub get , i am getting same issue

Can you hover on the issue and check whether it's a import issue or deprecation warning

mostly errors are due to argument cannot be assigned to parameter

Ok I will check

is their any update on these errors as i am still getting these errors and it's giving problem in the build and development of app. please tell if i am the only one facing the problem.

I have checked in my local system, I have not that issue you said.

@sainideepanshu199
Copy link
Author

i am getting errors in some files , can anyone tell why is this error image

The issue due to some unresolved third party package import maybe. Run flutter pub get and check whether the issue got fixed.

no even after running flutter pub get , i am getting same issue

Can you hover on the issue and check whether it's a import issue or deprecation warning

mostly errors are due to argument cannot be assigned to parameter

Ok I will check

is their any update on these errors as i am still getting these errors and it's giving problem in the build and development of app. please tell if i am the only one facing the problem.

I have checked in my local system, I have not that issue you said.

what shall i do then

@tanmoysrt
Copy link
Member

i am getting errors in some files , can anyone tell why is this error image

The issue due to some unresolved third party package import maybe. Run flutter pub get and check whether the issue got fixed.

no even after running flutter pub get , i am getting same issue

Can you hover on the issue and check whether it's a import issue or deprecation warning

mostly errors are due to argument cannot be assigned to parameter

Ok I will check

is their any update on these errors as i am still getting these errors and it's giving problem in the build and development of app. please tell if i am the only one facing the problem.

I have checked in my local system, I have not that issue you said.

what shall i do then

Try to run/build the app . Sometime the errors show due to vscode issues.

@sainideepanshu199 sainideepanshu199 closed this by deleting the head repository Mar 14, 2023
@sainideepanshu199
Copy link
Author

can anyone tell the status of this pr, does it has errors or is it not reviewed till now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmoysrt tanmoysrt tanmoysrt requested changes

@vedant-jain03 vedant-jain03 vedant-jain03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Button To Open Circuit Link In Browser
5 participants
@sainideepanshu199 @tanmoysrt @manjotsidhu @coveralls @vedant-jain03