Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version issue in 0.4.3 and test isn't written for setup.py? #61

Open
risner opened this issue May 30, 2021 · 2 comments
Open

version issue in 0.4.3 and test isn't written for setup.py? #61

risner opened this issue May 30, 2021 · 2 comments

Comments

@risner
Copy link

risner commented May 30, 2021

Here is a patch that fixes a compile issue that makes it not able to find clvm_tools in chia-blockchain-1.1.6:

--- pyproject.toml.orig	2021-05-30 14:12:11.254703000 -0400
+++ pyproject.toml	2021-05-30 14:11:35.404486000 -0400
@@ -3,5 +3,5 @@
 requires = ["setuptools>=42", "wheel", "setuptools_scm[toml]>=3.4"]

 [tool.setuptools_scm]
-fallback_version = "unknown"
+fallback_version = "0.4.3"
 local_scheme = "no-local-version"
@risner risner changed the title version issue in 0.4.3 version issue in 0.4.3 and test isn't written for setup.py? May 31, 2021
@risner
Copy link
Author

risner commented May 31, 2021

Also python3 setup.py test errors out:
File "/usr/local/lib/python3.8/site-packages/setuptools/command/test.py", line 55, in loadTestsFromModule
tests.append(self.loadTestsFromName(submodule))
File "/usr/local/lib/python3.8/unittest/loader.py", line 205, in loadTestsFromName
test = obj()
TypeError: patch_build_ext() missing 1 required positional argument: 'build_ext'

@richardkiss
Copy link
Contributor

The version issue is due to setuptools_scm, a handy but sometimes painful build tool which gets the version from the git log at build time. Setting the fallback_version is a good workaround for the FreeBSD port, but sort of defeats the purpose of using setuptools_scm in the first place.

And yeah, python setup.py test doesn't work with our setup.py at the moment. Use py.test tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants