Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add disallow_route and disallow_startup decorators and tests #135

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Nov 8, 2023

Replace disallow decorator with typed, working and tested disallow_route and disallow_startup. Due to difference in fastapi conventions, routes should raise HTTPException and not return errors, but the startup routing should not raise.

Adding separate decorators is the simplest workaround.

Add tests that tests the decorators with the fastapi decorators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant