Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop clvm-trait's dependency on clvmr #332

Merged
merged 1 commit into from
Dec 5, 2023
Merged

drop clvm-trait's dependency on clvmr #332

merged 1 commit into from
Dec 5, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Dec 4, 2023

remove the ToNodePtr and FromNodePtr traits as well as FromClvm and ToClvm for Allocator and NodePtr (those will be moved into clvmr).

This is one step in untangling the dependency cycle caused by making clvmr use chia-bls.

In order to keep everything building, all other crates that depend on clvm-traits now use the crates.io version (i.e. stay on the current version).

once this lands, clvm_rs can be updated to implement the clvm-traits. Then this repository can be restored to depend on the new clvm_rs and clvm-traits

@arvidn arvidn force-pushed the node-ptr-traits-1 branch 3 times, most recently from 5b338b1 to 9c2da1b Compare December 4, 2023 19:23
…romNodePtr traits as well as FromClvm and ToClvm for Allocator and NodePtr (those are moved into clvmr)
@arvidn arvidn force-pushed the node-ptr-traits-1 branch from 9c2da1b to 236ec8e Compare December 4, 2023 19:45
Copy link

Pull Request Test Coverage Report for Build 7091730462

  • 152 of 158 (96.2%) changed or added relevant lines in 3 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 86.244%

Changes Missing Coverage Covered Lines Changed/Added Lines %
clvm-traits/src/lib.rs 84 90 93.33%
Files with Coverage Reduction New Missed Lines %
clvm-traits/src/error.rs 1 0.0%
clvm-derive/src/helpers.rs 3 75.86%
clvm-traits/src/clvm_decoder.rs 3 0.0%
Totals Coverage Status
Change from base Build 7091231638: -0.08%
Covered Lines: 10840
Relevant Lines: 12569

💛 - Coveralls

Copy link
Contributor

@Rigidity Rigidity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't formally review, but here's some comments

chia-tools/Cargo.toml Show resolved Hide resolved
clvm-traits/docs/derive_macros.md Show resolved Hide resolved
clvm-traits/src/lib.rs Show resolved Hide resolved
clvm-traits/src/lib.rs Show resolved Hide resolved
@arvidn arvidn requested a review from Rigidity December 5, 2023 14:49
@arvidn arvidn merged commit b7d6812 into main Dec 5, 2023
54 checks passed
@arvidn arvidn deleted the node-ptr-traits-1 branch December 5, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants