Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clvm-traits rewrite with Encoder #317

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

Rigidity
Copy link
Contributor

No description provided.

@Rigidity Rigidity changed the title Clvm rewrite with Encoder traits Clvm-traits rewrite with Encoder Nov 17, 2023
clvm-traits/src/clvm_decoder.rs Show resolved Hide resolved
clvm-traits/src/from_clvm.rs Show resolved Hide resolved
clvm-traits/src/from_clvm.rs Show resolved Hide resolved
clvm-traits/src/from_clvm.rs Show resolved Hide resolved
clvm-traits/src/from_clvm.rs Show resolved Hide resolved
chia-wallet/src/proof.rs Show resolved Hide resolved
chia-wallet/src/puzzles/cat.rs Show resolved Hide resolved
clvm-traits/src/clvm_encoder.rs Show resolved Hide resolved
clvm-traits/src/to_clvm.rs Show resolved Hide resolved
clvm-traits/src/wrappers.rs Show resolved Hide resolved
Copy link

coveralls-official bot commented Nov 17, 2023

Pull Request Test Coverage Report for Build 6985071396

  • 254 of 332 (76.51%) changed or added relevant lines in 21 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.03%) to 85.857%

Changes Missing Coverage Covered Lines Changed/Added Lines %
clvm-traits/src/error.rs 1 2 50.0%
chia-wallet/src/puzzles/singleton.rs 0 3 0.0%
clvm-traits/src/clvm_decoder.rs 9 12 75.0%
clvm-traits/src/clvm_encoder.rs 10 13 76.92%
clvm-traits/src/wrappers.rs 3 6 50.0%
chia-wallet/src/puzzles/did.rs 5 9 55.56%
clvm-traits/src/to_clvm.rs 39 43 90.7%
chia-wallet/src/proof.rs 0 6 0.0%
clvm-traits/src/match_byte.rs 3 13 23.08%
clvm-traits/src/from_clvm.rs 57 76 75.0%
Files with Coverage Reduction New Missed Lines %
clvm-traits/src/match_byte.rs 1 23.53%
clvm-utils/src/curried_program.rs 1 97.22%
chia-wallet/src/puzzles/nft.rs 2 11.59%
Totals Coverage Status
Change from base Build 6984633742: 0.03%
Covered Lines: 10071
Relevant Lines: 11730

💛 - Coveralls

@Rigidity Rigidity requested a review from arvidn November 17, 2023 17:16
arvidn
arvidn previously approved these changes Nov 18, 2023
@arvidn
Copy link
Contributor

arvidn commented Nov 21, 2023

@arvidn
Copy link
Contributor

arvidn commented Nov 21, 2023

perhaps clvm and blspy aren't installed by the workflow. I wonder why it used to work though

@Rigidity
Copy link
Contributor Author

Looks like the other platforms passed, maybe it'll work if rerun

@arvidn arvidn closed this Nov 24, 2023
@arvidn arvidn reopened this Nov 24, 2023
@cmmarslender cmmarslender merged commit 1a5294e into Chia-Network:main Nov 27, 2023
101 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants