Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy issues #273

Merged
merged 3 commits into from
Sep 24, 2023
Merged

Fix clippy issues #273

merged 3 commits into from
Sep 24, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Sep 24, 2023

Apparently cargo clippy exits with status 0 even when there are warnings. This has missed some warnings in the wheel.

This PR fixes the warnings and also make CI fail in case clippy generates warnings.

@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 6288612532

  • 3 of 8 (37.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 90.276%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wheel/src/api.rs 0 5 0.0%
Totals Coverage Status
Change from base Build 6278022986: 0.002%
Covered Lines: 8615
Relevant Lines: 9543

💛 - Coveralls

@arvidn arvidn merged commit 49f4ce4 into main Sep 24, 2023
53 checks passed
@arvidn arvidn deleted the fix-clippy-issues branch September 24, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants