Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(core): input with error text are not shown #67

Closed
3 tasks done
Sukaato opened this issue Dec 5, 2024 · 0 comments · Fixed by #68
Closed
3 tasks done

bug(core): input with error text are not shown #67

Sukaato opened this issue Dec 5, 2024 · 0 comments · Fixed by #68
Assignees
@Sukaato
Labels
bug Something isn't working package: core @poppy-ui/core package related
Milestone
v1.0.0

Comments

@Sukaato
Copy link
Member

Sukaato commented Dec 5, 2024

Prerequisites

Poppy UI Version

v1.x

Current Behavior

When a error-text is defined, this not showed up due to css selector
:host>.input-wrapper:not(:user-invalid)+.text-wrapper>.error-text

Expected Behavior

show the error text if is not empty

Steps to Reproduce

.

Code Reproduction URL

No response

Additional Information

No response
@Sukaato Sukaato added the bug Something isn't working label Dec 5, 2024
@github-actions github-actions bot added the package: core @poppy-ui/core package related label Dec 5, 2024
@Sukaato Sukaato self-assigned this Dec 5, 2024
@Sukaato Sukaato added this to the v1.0.0 milestone Dec 5, 2024
Sukaato added a commit that referenced this issue Dec 5, 2024
@Sukaato
fix(input): display error text
876a432 
new behavior:
- display helper text by default
- display error text if present
- hide helper text if error text is present
- add text ellipsis on input

fixes: #67
@Sukaato Sukaato mentioned this issue Dec 5, 2024
Merged
2 tasks
@Sukaato Sukaato closed this as completed in d3b3dcd Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sukaato Sukaato

Labels
bug Something isn't working package: core @poppy-ui/core package related
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

fix(input): display error text CheeseGrinder/poppy-ui
1 participant
@Sukaato