Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration (core): Migrate the @import scss rule #59

Closed
Sukaato opened this issue Nov 19, 2024 · 0 comments · Fixed by #66
Closed

migration (core): Migrate the @import scss rule #59

Sukaato opened this issue Nov 19, 2024 · 0 comments · Fixed by #66
Assignees
@Sukaato
Labels
dependencies Pull requests that update a dependency file package: core @poppy-ui/core package related
Milestone
v1.0.0

Comments

@Sukaato
Copy link
Member

Sukaato commented Nov 19, 2024

Currently, Poppy use the scss rule @import, but this one is gonna be deprecated, so to big migration in the futur and breaking all of the style, we're migrating ASAP

SASS tell us to replace @import by @use and @forward rule
@Sukaato Sukaato added dependencies Pull requests that update a dependency file package: core @poppy-ui/core package related labels Nov 19, 2024
@Sukaato Sukaato added this to the v1.0.0 milestone Nov 19, 2024
@Sukaato Sukaato self-assigned this Nov 19, 2024
@Sukaato Sukaato mentioned this issue Dec 3, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sukaato Sukaato

Labels
dependencies Pull requests that update a dependency file package: core @poppy-ui/core package related
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

refactor(core): migrate @import rule to @use and @forward CheeseGrinder/poppy-ui
1 participant
@Sukaato