Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The PolicyCleanUP doesn't work with policy packages with inline layers #7

Open
KostasGRCP opened this issue Jan 15, 2021 · 4 comments

Comments

@KostasGRCP
Copy link

Hello

We have tested the latest version of the PolicyCleanUp.py and it seems that it doesn't work with policy packages with inline layers
Can you please test/confirm?

Thank you
Kostas

@chkp-yaelg
Copy link
Contributor

Hi @KostasGRCP ,
We will test that case and we will inform you about our findings.

@simonmacpherson
Copy link

Hello,

I noticed the parent rules of inline layers within policies that script runs against are denoted as changed by the clean up script but they remain enabled. Though there are rules within the layer that have not been disabled but possibly should have been.

This might indicate the script doesn’t fully support in-line layers at this stage.

@chkp-royl @chkp-yaelg
Are you able to confirm this? If they are not supported at this stage, can you provide an estimate of when they can be supported?

Regards,
Simon

@chkp-royl
Copy link
Contributor

Hi @simonmacpherson ,
Sorry but we don't have plan or ETA to support inline layers.
Since this tool is public open source, I encourage you to contribute to this project and we will review your pool request.

Regards,
Roy

@pablotelianet
Copy link

Hi

We are a customer also and try to use the inline part, but not working at the moment, we appreciate this feature if possible

Regards
Pablo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants