Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make two public header files private #12

Open
ma11hew28 opened this issue Dec 3, 2017 · 0 comments
Open

Make two public header files private #12

ma11hew28 opened this issue Dec 3, 2017 · 0 comments

Comments

@ma11hew28
Copy link

Shouldn't SignalCommonCryptoProvider.h be private? And, shouldn't SignalPreKeyMessage.h be private like SignalMessage.h?

I can't think of any good reasons that an application using SignalProtocol-ObjC would need to know about SignalCommonCryptoProvider and/or its instance method cryptoProvider or SignalPreKeyMessage and/or its designated initializer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ma11hew28