diff --git a/app/components/chat.tsx b/app/components/chat.tsx
index 35e45480a4a..82d6c6e398a 100644
--- a/app/components/chat.tsx
+++ b/app/components/chat.tsx
@@ -149,7 +149,8 @@ export function SessionConfigModel(props: { onClose: () => void }) {
text={Locale.Chat.Config.Reset}
onClick={async () => {
if (await showConfirm(Locale.Memory.ResetConfirm)) {
- chatStore.updateCurrentSession(
+ chatStore.updateTargetSession(
+ session,
(session) => (session.memoryPrompt = ""),
);
}
@@ -174,7 +175,10 @@ export function SessionConfigModel(props: { onClose: () => void }) {
updateMask={(updater) => {
const mask = { ...session.mask };
updater(mask);
- chatStore.updateCurrentSession((session) => (session.mask = mask));
+ chatStore.updateTargetSession(
+ session,
+ (session) => (session.mask = mask),
+ );
}}
shouldSyncFromGlobal
extraListItems={
@@ -346,12 +350,14 @@ export function PromptHints(props: {
function ClearContextDivider() {
const chatStore = useChatStore();
+ const session = chatStore.currentSession();
return (
- chatStore.updateCurrentSession(
+ chatStore.updateTargetSession(
+ session,
(session) => (session.clearContextIndex = undefined),
)
}
@@ -461,6 +467,7 @@ export function ChatActions(props: {
const navigate = useNavigate();
const chatStore = useChatStore();
const pluginStore = usePluginStore();
+ const session = chatStore.currentSession();
// switch themes
const theme = config.theme;
@@ -477,10 +484,9 @@ export function ChatActions(props: {
const stopAll = () => ChatControllerPool.stopAll();
// switch model
- const currentModel = chatStore.currentSession().mask.modelConfig.model;
+ const currentModel = session.mask.modelConfig.model;
const currentProviderName =
- chatStore.currentSession().mask.modelConfig?.providerName ||
- ServiceProvider.OpenAI;
+ session.mask.modelConfig?.providerName || ServiceProvider.OpenAI;
const allModels = useAllModels();
const models = useMemo(() => {
const filteredModels = allModels.filter((m) => m.available);
@@ -514,12 +520,9 @@ export function ChatActions(props: {
const dalle3Sizes: DalleSize[] = ["1024x1024", "1792x1024", "1024x1792"];
const dalle3Qualitys: DalleQuality[] = ["standard", "hd"];
const dalle3Styles: DalleStyle[] = ["vivid", "natural"];
- const currentSize =
- chatStore.currentSession().mask.modelConfig?.size ?? "1024x1024";
- const currentQuality =
- chatStore.currentSession().mask.modelConfig?.quality ?? "standard";
- const currentStyle =
- chatStore.currentSession().mask.modelConfig?.style ?? "vivid";
+ const currentSize = session.mask.modelConfig?.size ?? "1024x1024";
+ const currentQuality = session.mask.modelConfig?.quality ?? "standard";
+ const currentStyle = session.mask.modelConfig?.style ?? "vivid";
const isMobileScreen = useMobileScreen();
@@ -537,7 +540,7 @@ export function ChatActions(props: {
if (isUnavailableModel && models.length > 0) {
// show next model to default model if exist
let nextModel = models.find((model) => model.isDefault) || models[0];
- chatStore.updateCurrentSession((session) => {
+ chatStore.updateTargetSession(session, (session) => {
session.mask.modelConfig.model = nextModel.name;
session.mask.modelConfig.providerName = nextModel?.provider
?.providerName as ServiceProvider;
@@ -548,7 +551,7 @@ export function ChatActions(props: {
: nextModel.name,
);
}
- }, [chatStore, currentModel, models]);
+ }, [chatStore, currentModel, models, session]);
return (
@@ -615,7 +618,7 @@ export function ChatActions(props: {
text={Locale.Chat.InputActions.Clear}
icon={}
onClick={() => {
- chatStore.updateCurrentSession((session) => {
+ chatStore.updateTargetSession(session, (session) => {
if (session.clearContextIndex === session.messages.length) {
session.clearContextIndex = undefined;
} else {
@@ -647,7 +650,7 @@ export function ChatActions(props: {
onSelection={(s) => {
if (s.length === 0) return;
const [model, providerName] = getModelProvider(s[0]);
- chatStore.updateCurrentSession((session) => {
+ chatStore.updateTargetSession(session, (session) => {
session.mask.modelConfig.model = model as ModelType;
session.mask.modelConfig.providerName =
providerName as ServiceProvider;
@@ -685,7 +688,7 @@ export function ChatActions(props: {
onSelection={(s) => {
if (s.length === 0) return;
const size = s[0];
- chatStore.updateCurrentSession((session) => {
+ chatStore.updateTargetSession(session, (session) => {
session.mask.modelConfig.size = size;
});
showToast(size);
@@ -712,7 +715,7 @@ export function ChatActions(props: {
onSelection={(q) => {
if (q.length === 0) return;
const quality = q[0];
- chatStore.updateCurrentSession((session) => {
+ chatStore.updateTargetSession(session, (session) => {
session.mask.modelConfig.quality = quality;
});
showToast(quality);
@@ -739,7 +742,7 @@ export function ChatActions(props: {
onSelection={(s) => {
if (s.length === 0) return;
const style = s[0];
- chatStore.updateCurrentSession((session) => {
+ chatStore.updateTargetSession(session, (session) => {
session.mask.modelConfig.style = style;
});
showToast(style);
@@ -770,7 +773,7 @@ export function ChatActions(props: {
}))}
onClose={() => setShowPluginSelector(false)}
onSelection={(s) => {
- chatStore.updateCurrentSession((session) => {
+ chatStore.updateTargetSession(session, (session) => {
session.mask.plugin = s as string[];
});
}}
@@ -813,7 +816,8 @@ export function EditMessageModal(props: { onClose: () => void }) {
icon={}
key="ok"
onClick={() => {
- chatStore.updateCurrentSession(
+ chatStore.updateTargetSession(
+ session,
(session) => (session.messages = messages),
);
props.onClose();
@@ -830,7 +834,8 @@ export function EditMessageModal(props: { onClose: () => void }) {
type="text"
value={session.topic}
onInput={(e) =>
- chatStore.updateCurrentSession(
+ chatStore.updateTargetSession(
+ session,
(session) => (session.topic = e.currentTarget.value),
)
}
@@ -991,7 +996,8 @@ function _Chat() {
prev: () => chatStore.nextSession(-1),
next: () => chatStore.nextSession(1),
clear: () =>
- chatStore.updateCurrentSession(
+ chatStore.updateTargetSession(
+ session,
(session) => (session.clearContextIndex = session.messages.length),
),
fork: () => chatStore.forkSession(),
@@ -1062,7 +1068,7 @@ function _Chat() {
};
useEffect(() => {
- chatStore.updateCurrentSession((session) => {
+ chatStore.updateTargetSession(session, (session) => {
const stopTiming = Date.now() - REQUEST_TIMEOUT_MS;
session.messages.forEach((m) => {
// check if should stop all stale messages
@@ -1088,7 +1094,7 @@ function _Chat() {
}
});
// eslint-disable-next-line react-hooks/exhaustive-deps
- }, []);
+ }, [session]);
// check if should send message
const onInputKeyDown = (e: React.KeyboardEvent) => {
@@ -1119,7 +1125,8 @@ function _Chat() {
};
const deleteMessage = (msgId?: string) => {
- chatStore.updateCurrentSession(
+ chatStore.updateTargetSession(
+ session,
(session) =>
(session.messages = session.messages.filter((m) => m.id !== msgId)),
);
@@ -1186,7 +1193,7 @@ function _Chat() {
};
const onPinMessage = (message: ChatMessage) => {
- chatStore.updateCurrentSession((session) =>
+ chatStore.updateTargetSession(session, (session) =>
session.mask.context.push(message),
);
@@ -1712,14 +1719,17 @@ function _Chat() {
});
}
}
- chatStore.updateCurrentSession((session) => {
- const m = session.mask.context
- .concat(session.messages)
- .find((m) => m.id === message.id);
- if (m) {
- m.content = newContent;
- }
- });
+ chatStore.updateTargetSession(
+ session,
+ (session) => {
+ const m = session.mask.context
+ .concat(session.messages)
+ .find((m) => m.id === message.id);
+ if (m) {
+ m.content = newContent;
+ }
+ },
+ );
}}
>
diff --git a/app/store/chat.ts b/app/store/chat.ts
index 4208692e270..e2dbe90b026 100644
--- a/app/store/chat.ts
+++ b/app/store/chat.ts
@@ -357,7 +357,7 @@ export const useChatStore = createPersistStore(
session.messages = session.messages.concat();
session.lastUpdate = Date.now();
});
- get().updateStat(message);
+ get().updateStat(message, targetSession);
get().summarizeSession(false, targetSession);
},
@@ -396,10 +396,10 @@ export const useChatStore = createPersistStore(
// get recent messages
const recentMessages = get().getMessagesWithMemory();
const sendMessages = recentMessages.concat(userMessage);
- const messageIndex = get().currentSession().messages.length + 1;
+ const messageIndex = session.messages.length + 1;
// save user's and bot's message
- get().updateCurrentSession((session) => {
+ get().updateTargetSession(session, (session) => {
const savedUserMessage = {
...userMessage,
content: mContent,
@@ -420,7 +420,7 @@ export const useChatStore = createPersistStore(
if (message) {
botMessage.content = message;
}
- get().updateCurrentSession((session) => {
+ get().updateTargetSession(session, (session) => {
session.messages = session.messages.concat();
});
},
@@ -434,7 +434,7 @@ export const useChatStore = createPersistStore(
},
onBeforeTool(tool: ChatMessageTool) {
(botMessage.tools = botMessage?.tools || []).push(tool);
- get().updateCurrentSession((session) => {
+ get().updateTargetSession(session, (session) => {
session.messages = session.messages.concat();
});
},
@@ -444,7 +444,7 @@ export const useChatStore = createPersistStore(
tools[i] = { ...tool };
}
});
- get().updateCurrentSession((session) => {
+ get().updateTargetSession(session, (session) => {
session.messages = session.messages.concat();
});
},
@@ -459,7 +459,7 @@ export const useChatStore = createPersistStore(
botMessage.streaming = false;
userMessage.isError = !isAborted;
botMessage.isError = !isAborted;
- get().updateCurrentSession((session) => {
+ get().updateTargetSession(session, (session) => {
session.messages = session.messages.concat();
});
ChatControllerPool.remove(
@@ -591,8 +591,8 @@ export const useChatStore = createPersistStore(
set(() => ({ sessions }));
},
- resetSession() {
- get().updateCurrentSession((session) => {
+ resetSession(session: ChatSession) {
+ get().updateTargetSession(session, (session) => {
session.messages = [];
session.memoryPrompt = "";
});
@@ -736,19 +736,12 @@ export const useChatStore = createPersistStore(
}
},
- updateStat(message: ChatMessage) {
- get().updateCurrentSession((session) => {
+ updateStat(message: ChatMessage, session: ChatSession) {
+ get().updateTargetSession(session, (session) => {
session.stat.charCount += message.content.length;
// TODO: should update chat count and word count
});
},
-
- updateCurrentSession(updater: (session: ChatSession) => void) {
- const sessions = get().sessions;
- const index = get().currentSessionIndex;
- updater(sessions[index]);
- set(() => ({ sessions }));
- },
updateTargetSession(
targetSession: ChatSession,
updater: (session: ChatSession) => void,