Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unit tests - SAMP hub connection problem when running multiple test files. #3

Open
jbudynk opened this issue Feb 17, 2015 · 0 comments
Open

fix unit tests - SAMP hub connection problem when running multiple test files. #3

jbudynk opened this issue Feb 17, 2015 · 0 comments

Comments

@jbudynk
Copy link
Member

jbudynk commented Feb 17, 2015

The unit tests do not start/stop the hub correctly when we run the tests all together. For example, cding into the sherpa_samp/sedstacker/tests directory and running nosetests will cause errors relating to the SAMP hub connection. The tests pass if you run the tests individually.

We should remove the dependency on the SAMP hub from the unit tests. Instead, create a mock-SAMP hub to run the tests. We can make a new test to test connecting to a SAMP hub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbudynk