Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to container queries #5

Open
thomaswilburn opened this issue Jun 7, 2023 · 0 comments
Open

Convert to container queries #5

thomaswilburn opened this issue Jun 7, 2023 · 0 comments

Comments

@thomaswilburn
Copy link
Member

thomaswilburn commented Jun 7, 2023

We do a lot of small multiples in the rig, and that causes problems when the graphic is sized according to the viewport, so it makes visual choices like a big chart even though it's very small. By switching to container queries, we can avoid this completely. We may need to pick a standard wrapper class for charts to make that possible, or we can just continue hanging it on .graphic and make sure we use that consistently.

We can make this change when Safari 18 drops, since that will mean 2 major versions of support there, and it's the big laggard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant