-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup the React Components project #60
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very unfamiliar with this type of project, so I've just added a few basic comments. What can I do to help document this project?
Co-authored-by: Dan Forbes <[email protected]>
Thanks Dan; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry but I can't accept any PR like this. i asked you to recreate your branch from main as this PR contains commits that are already merged. Why do you modify files in circle-demo-webapp and web3-circle-sdk? also notice other files in the screen below that you want to add with this PR. Please clean this up, and offer minimal package that exports a single component for publishing. As an example you can copy one of the components from the demo app and test it manually end-to-end.
No description provided.