Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup the React Components project #60

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

Muhammad-Altabba
Copy link
Member

No description provided.

@Muhammad-Altabba Muhammad-Altabba linked an issue Dec 9, 2024 that may be closed by this pull request
@Muhammad-Altabba Muhammad-Altabba changed the title setup the React Components project [DRAFT] setup the React Components project Dec 10, 2024
@Muhammad-Altabba Muhammad-Altabba marked this pull request as ready for review December 11, 2024 15:05
@Muhammad-Altabba Muhammad-Altabba changed the title [DRAFT] setup the React Components project Setup the React Components project Dec 11, 2024
@Muhammad-Altabba Muhammad-Altabba requested review from krzysu, avkos and danforbes and removed request for krzysu and avkos December 11, 2024 20:55
Copy link
Contributor

@danforbes danforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very unfamiliar with this type of project, so I've just added a few basic comments. What can I do to help document this project?

packages/circle-react-components/.nvmrc Outdated Show resolved Hide resolved
packages/circle-react-components/README.md Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
@Muhammad-Altabba
Copy link
Member Author

Muhammad-Altabba commented Dec 11, 2024

I'm very unfamiliar with this type of project, so I've just added a few basic comments. What can I do to help document this project?

Thanks Dan;
I think the documentation needs to come once the React Components are moved here.
I addressed all your comments. Feel free to add more if you will find.

Copy link
Contributor

@krzysu krzysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry but I can't accept any PR like this. i asked you to recreate your branch from main as this PR contains commits that are already merged. Why do you modify files in circle-demo-webapp and web3-circle-sdk? also notice other files in the screen below that you want to add with this PR. Please clean this up, and offer minimal package that exports a single component for publishing. As an example you can copy one of the components from the demo app and test it manually end-to-end.

Screenshot 2024-12-12 at 09 41 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Components Project Setup
4 participants