Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Components Project Setup #54

Open
Muhammad-Altabba opened this issue Dec 5, 2024 · 4 comments · May be fixed by #60
Open

React Components Project Setup #54

Muhammad-Altabba opened this issue Dec 5, 2024 · 4 comments · May be fixed by #60
Assignees

Comments

@Muhammad-Altabba
Copy link
Member

Setup a project that will publish the React Components to the npm registry.

@Muhammad-Altabba
Copy link
Member Author

The added project will be generated from https://github.com/IgnacioNMiranda/vite-component-library-template and them modified and integrated into the mono repo. Then the React Components could be added to it...

@krzysu
Copy link
Contributor

krzysu commented Dec 9, 2024

@Muhammad-Altabba why? I have all what is needed for react components already setup in my branch, see branch circle-webapp-2. The project you mentioned contains a lot of unnecessary or duplicated tools. I thought you are preparing a simple empty npm package.

@Muhammad-Altabba Muhammad-Altabba linked a pull request Dec 9, 2024 that will close this issue
@Muhammad-Altabba
Copy link
Member Author

Muhammad-Altabba commented Dec 9, 2024

@Muhammad-Altabba why? I have all what is needed for react components already setup in my branch, see branch circle-webapp-2. The project you mentioned contains a lot of unnecessary or duplicated tools. I thought you are preparing a simple empty npm package.

Thanks @krzysu,
As we agreed in our last 1 to 1 meeting that was to prepare an empty project ready to put the react components in to use it to publish to the npm registry (I published a test from the current draft branch: https://www.npmjs.com/package/web3-circle-react-components-test). And the template that I chose is well-documented and a bit popular (about 200 stars). But we can change it for a better alternative.
In all cases, no issues, I am happy to meet to discuss and sync again...

@krzysu
Copy link
Contributor

krzysu commented Dec 10, 2024

as discussed today in person, let's continue with a new package for circle react components. let me know when ready and I will move my components there and test importing them in the demo app. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants