Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3_provider tests depend on external source #7250

Open
nflaig opened this issue Nov 27, 2024 · 3 comments
Open

web3_provider tests depend on external source #7250

nflaig opened this issue Nov 27, 2024 · 3 comments
Labels
scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.

Comments

@nflaig
Copy link
Member

nflaig commented Nov 27, 2024

The web3_provider tests in the prover package depend on a external source (our public sepolia node) to run correctly.

urls: ["https://lodestar-sepolia.chainsafe.io"],

This behavior is not deterministic and we should not depend on external sources when running tests, especially unit tests.

@nflaig nflaig added the scope-testing Issues for adding test coverage, fixing existing tests or testing strategies. label Nov 27, 2024
@nazarhussain
Copy link
Contributor

The reason we kept it as unit tests is to run the same tests in browser. All unit tests runs in the browsers in current configuration.

@philknows
Copy link
Member

Is there a reason why we have to use our public Sepolia node for this? We do not have much redundant infrastructure for this network incase the endpoint goes down. So if it needs re-syncing, this test is blocked until it's re-synced. We have more redundant infrastructure for mainnet if we can run against any network?

@nflaig
Copy link
Member Author

nflaig commented Dec 2, 2024

We have more redundant infrastructure for mainnet if we can run against any network?

This should work, I still think we should move those to e2e tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.
Projects
None yet
Development

No branches or pull requests

3 participants