Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment typo in setup.sh in line 297 #14

Open
dranol2021 opened this issue Apr 19, 2023 · 2 comments
Open

Comment typo in setup.sh in line 297 #14

dranol2021 opened this issue Apr 19, 2023 · 2 comments
Assignees

Comments

@dranol2021
Copy link

https://github.com/ChainSafe/lodestar-quickstart/blob/main/setup.sh
I am not quite sure, but I think there is a minor comment typo in the setup.sh script in line 297:

Instead of

keystoreDir is where the keystores are to be expected, ...

it should be

keystoresDir is where the keystores are to be expected, ...

@philknows
Copy link
Member

@g11tech Correct me if I'm wrong, I don't think this is a typo here specifically as it refers to how setup.sh handles the keystores directory and referencing it internally as keystoreDir.

Maybe we should keep it consistent and change it all to use keystoresDir as a reference?

@g11tech
Copy link
Contributor

g11tech commented Sep 20, 2023

correct @philknows , its internal docker mount point, could be changed to keystoresDir, will include it in a future PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@philknows @g11tech @dranol2021 and others