Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only send window update when read state is ready #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wemeetagain
Copy link
Member

@danisharora099 can you run your test against this branch to confirm that it fixes your issue?

@wemeetagain wemeetagain requested review from achingbrain and a team as code owners October 10, 2024 16:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.20%. Comparing base (96bfe96) to head (0b67386).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/stream.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   95.28%   95.20%   -0.08%     
==========================================
  Files          15       15              
  Lines        2268     2273       +5     
  Branches      343      344       +1     
==========================================
+ Hits         2161     2164       +3     
- Misses        107      109       +2     
Flag Coverage Δ
node 95.20% <60.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danisharora099
Copy link

danisharora099 commented Oct 10, 2024

thanks for the effort @wemeetagain !
can I find a release candidate for this?

@wemeetagain
Copy link
Member Author

should be published as @chainsafe/[email protected]

@danisharora099
Copy link

danisharora099 commented Oct 14, 2024

Couldn't validate this on my end on js-waku -- still seeing STREAM_RESET against nim-waku

cc'ing @diegomrsantos if he could help validate it's interop with js-libp2p <> nim-libp2p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yamux pontentially sending a WindowUpdate after it has closed the stream
3 participants