refactor: make components and logger optional #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous releases of yamux the following was supported:
import { yamux } from '@chainsafe/libp2p-yamux'
const muxer = yamux()()
Now the following is required:
import { yamux } from '@chainsafe/libp2p-yamux'
const muxer = yamux()({logger: ...})
Adjust the code to support passing an empty logger and an empty Components.
Fixes ChainSafe#69
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Dec 1, 2023
Update dependencies and fix various breaking changes introduced by those dependency updates: - Change type of Conn to Duplex<Uint8Array | Uint8ArrayList> - Pass a logger stub to yamux as it's now required. The logger stub should not be necessary once these are fixed: - ChainSafe/js-libp2p-yamux#69 - libp2p/js-libp2p#2275 - ChainSafe/js-libp2p-yamux#70 Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Dec 1, 2023
NOTE: The following issues must be addressed before this is merged: libp2p/interface is currently held at version 0.1.2: - Passing a logger to MuxerInit is now required (should be optional?): libp2p/js-libp2p#2275 @chainsafe/libp2p-yamux is currently held at version 5.0.4: - Passing a logger to yamux()({logger:...}) is now required (should be optional?): ChainSafe/js-libp2p-yamux#69 - The integration test for rpcstream fails with 6.x vs. 5.x: ChainSafe/js-libp2p-yamux#71 and https://github.com/aperturerobotics/starpc/actions/runs/7055030516/job/19204891175 See: #120 --- Update dependencies and fix various breaking changes introduced by those dependency updates: - Change type of Conn to Duplex<Uint8Array | Uint8ArrayList> - Pass a logger stub to yamux as it's now required. The logger stub should not be necessary once these are fixed: - ChainSafe/js-libp2p-yamux#69 - libp2p/js-libp2p#2275 - ChainSafe/js-libp2p-yamux#70 Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Dec 11, 2023
NOTE: The following issues must be addressed before this is merged: libp2p/interface is currently held at version 0.1.2: - Passing a logger to MuxerInit is now required (should be optional?): libp2p/js-libp2p#2275 @chainsafe/libp2p-yamux is currently held at version 5.0.4: - Passing a logger to yamux()({logger:...}) is now required (should be optional?): ChainSafe/js-libp2p-yamux#69 - The integration test for rpcstream fails with 6.x vs. 5.x: ChainSafe/js-libp2p-yamux#71 and https://github.com/aperturerobotics/starpc/actions/runs/7055030516/job/19204891175 See: #120 --- Update dependencies and fix various breaking changes introduced by those dependency updates: - Change type of Conn to Duplex<Uint8Array | Uint8ArrayList> - Pass a logger stub to yamux as it's now required. The logger stub should not be necessary once these are fixed: - ChainSafe/js-libp2p-yamux#69 - libp2p/js-libp2p#2275 - ChainSafe/js-libp2p-yamux#70 Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Jan 10, 2024
NOTE: The following issues must be addressed before this is merged: libp2p/interface is currently held at version 0.1.2: - Passing a logger to MuxerInit is now required (should be optional?): libp2p/js-libp2p#2275 @chainsafe/libp2p-yamux is currently held at version 5.0.4: - Passing a logger to yamux()({logger:...}) is now required (should be optional?): ChainSafe/js-libp2p-yamux#69 - The integration test for rpcstream fails with 6.x vs. 5.x: ChainSafe/js-libp2p-yamux#71 and https://github.com/aperturerobotics/starpc/actions/runs/7055030516/job/19204891175 See: #120 --- Update dependencies and fix various breaking changes introduced by those dependency updates: - Change type of Conn to Duplex<Uint8Array | Uint8ArrayList> - Pass a logger stub to yamux as it's now required. The logger stub should not be necessary once these are fixed: - ChainSafe/js-libp2p-yamux#69 - libp2p/js-libp2p#2275 - ChainSafe/js-libp2p-yamux#70 Signed-off-by: Christian Stewart <[email protected]>
|
I give up on this and will just pass a stub Log from now on. |
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Jan 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass a logger stub to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Jan 17, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass a logger stub to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Jan 17, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass a logger stub to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Feb 7, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass a logger stub to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Feb 7, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Feb 9, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
paralin
added a commit
to aperturerobotics/starpc
that referenced
this pull request
Feb 10, 2024
- Passing a logger to MuxerInit is now required
- Passing a logger to yamux()({logger:...}) is now required
See: #120
Update dependencies and fix various breaking changes introduced by those
dependency updates:
- Change type of Conn to Duplex<Uint8Array | Uint8ArrayList>
- Pass default logger to yamux as it's now required.
- We need to pass a Uint8ArrayList to the WebSocket it-ws.
Related:
- ChainSafe/js-libp2p-yamux#69
- libp2p/js-libp2p#2275
- ChainSafe/js-libp2p-yamux#70
Signed-off-by: Christian Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous releases of yamux the following was supported:
Now the following is required:
Adjust the code to support passing an empty logger and an empty Components.
Fixes #69