Implement automation for archival snapshots #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-shashank
force-pushed
the
shashank/archival-snapshots
branch
from
f4de8c7 to
47630a4
Compare
sudo-shashank
force-pushed
the
shashank/archival-snapshots
branch
from
3c67b82 to
c8afdd4
Compare
sudo-shashank
requested review from
ruseinov and
hanabi1224
and removed request for
a team
lemmih
requested changes
Apr 3, 2024
There was a problem hiding this comment.
Good start. There are a few things that need to be addressed:
- The code appears to be fragile. If
awsorrubyare missing, the code will fail silently. If there's an error in the script, the code will fail silently. If the snapshots aren't exported or uploaded correctly, the code will fail silently. - There are a lot of assumptions about Archie that aren't guaranteed to hold:
- You can't assume
awsis installed. - You can't assume
forestis installed. - You can't assume a Forest node is running.
- You can't assume Ruby is installed.
- You can't assume
|
Also, please describe your solution/changes in the PR description. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
3 tasks
sudo-shashank
force-pushed
the
shashank/archival-snapshots
branch
from
77f1e96 to
d8aa928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #414
Other information and links