Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent dynamic geometry update if time hasn't change #8078

Open
mpnewcomb opened this issue Aug 15, 2019 · 1 comment
Open

Prevent dynamic geometry update if time hasn't change #8078

mpnewcomb opened this issue Aug 15, 2019 · 1 comment

Comments

@mpnewcomb
Copy link

I have a 8 Polyline Entities. I'm not quite sure how many points, but probably quite a few because there are curves approximated by lines. Cesium was extremely sluggish while zooming in/out and panning around. Profiled the app and rendering is taking 250ms. I look further and see Clock.tick... I'm not advancing time, but still this is being called... look further and see Viewer_onTick->DataSourceDisplay.update->PolylineVisualizer.update->DynamicGeometryBatch.update->DynamicGeometryUpdater.update and watch as it basically destroys all my polylines... only for Scene.render to recreate them!? And, time has not changed!

Somewhere along that chain, somebody needs to check to see if time has actually changed before doing all that work.

@emackey
Copy link
Contributor

emackey commented Aug 16, 2019

This is a subset of a larger issue #2310. Probably worth doing this as low-hanging fruit, but the deeper problem is more involved.

@OmarShehata OmarShehata changed the title Anything with update(time) needs to see if time actually changed before doing work... Prevent dynamic geometry update if time hasn't change Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants