Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolygonGeometry with holes have broken surfaces #12294

Open
ArgentumHHH opened this issue Nov 8, 2024 · 1 comment
Open

PolygonGeometry with holes have broken surfaces #12294

ArgentumHHH opened this issue Nov 8, 2024 · 1 comment
Labels

Comments

@ArgentumHHH
Copy link

What happened?

Now I have encountered a problem when changing from version 1.119 to versions after 1.120.
I created a PolygonGeometry that provides polygon boundary coordinate data and polygon hole coordinate data to create a polygon with holes. Generally, there is no problem with the coordinate data of holes, but many boundary coordinates in urban areas may have holes and broken surfaces.
The city boundary coordinate data is arranged in order and is valid latitude and longitude data in terms of format. It can be successfully rendered as PolylineGeometry or PolygonGeometry, but using the city coordinate data as polygon hole coordinate data may result in broken surfaces.

PolygonGeometry with holes created in version 1.119:
1 119

PolygonGeometry with holes created in version 1.120 has a broken surface in the lower left corner, and most of the city boundary coordinates have a broken surface in the lower left corner:
1 120

Reproduction steps

No response

Sandcastle example

No response

Environment

Browser:
CesiumJS Version:
Operating System:

@ggetz
Copy link
Contributor

ggetz commented Nov 13, 2024

Thanks for raising this issue @ArgentumHHH!

Looking through the 1.120 changelog, I don't see anything obvious that may have broken polygon hole rendering. It would be helpful to do a git bisect to determine the commit which caused the regression.

@ArgentumHHH Is this something you would be able to try?

@ggetz ggetz added the needs feedback On hold until additional info is supplied label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants