You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently tasks self.validate() is not really ran anywhere, neither at submission or during the task executions.
Expected Behavior
In principle, it should by default ran anytime run() is called because you want to validate all parameters before running the task.
During submission However, sometimes some attribute such as self.samples are not populated yet until the whole batch is ready (like in heating). So the validate() method should not be called during running. Otherwise we would need two base methods such as validate_run() and validate_submission()
Minimal example
No response
Relevant files/images/logs
No response
The text was updated successfully, but these errors were encountered:
Im voting for just having something like validate_before_running() as a method that is called by default before any task is running if this is the design intention. However, I like it better when before submission, all checking is done. So validate should not be called directly before run(), but rather after all samples have been instantiated with all tasks and batched.
Current behavior
Currently tasks self.validate() is not really ran anywhere, neither at submission or during the task executions.
Expected Behavior
In principle, it should by default ran anytime run() is called because you want to validate all parameters before running the task.
During submission However, sometimes some attribute such as self.samples are not populated yet until the whole batch is ready (like in heating). So the validate() method should not be called during running. Otherwise we would need two base methods such as validate_run() and validate_submission()
Minimal example
No response
Relevant files/images/logs
No response
The text was updated successfully, but these errors were encountered: