Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tasks self.validate() is not actually run anywhere #73

Open
bernardusrendy opened this issue Jun 16, 2024 · 1 comment
Open

[Bug]: Tasks self.validate() is not actually run anywhere #73

bernardusrendy opened this issue Jun 16, 2024 · 1 comment
Labels
bug not't working as it should be

Comments

@bernardusrendy
Copy link
Collaborator

Current behavior

Currently tasks self.validate() is not really ran anywhere, neither at submission or during the task executions.

Expected Behavior

In principle, it should by default ran anytime run() is called because you want to validate all parameters before running the task.

During submission However, sometimes some attribute such as self.samples are not populated yet until the whole batch is ready (like in heating). So the validate() method should not be called during running. Otherwise we would need two base methods such as validate_run() and validate_submission()

Minimal example

No response

Relevant files/images/logs

No response

@bernardusrendy bernardusrendy added the bug not't working as it should be label Jun 16, 2024
@bernardusrendy
Copy link
Collaborator Author

bernardusrendy commented Jun 16, 2024

Im voting for just having something like validate_before_running() as a method that is called by default before any task is running if this is the design intention. However, I like it better when before submission, all checking is done. So validate should not be called directly before run(), but rather after all samples have been instantiated with all tasks and batched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug not't working as it should be
Projects
None yet
Development

No branches or pull requests

1 participant