Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: extract common logic, checking if a reserved keyword is used, from let, const and assign resources to avoid code duplication. #530

Open
dastin-sandura opened this issue Oct 30, 2020 · 1 comment · May be fixed by #541
Open

Refactor: extract common logic, checking if a reserved keyword is used, from let, const and assign resources to avoid code duplication. #530

dastin-sandura opened this issue Oct 30, 2020 · 1 comment · May be fixed by #541
Labels
enhancement New feature or request

Comments

@dastin-sandura
Copy link
Contributor

Is your feature request related to a problem? If yes, please describe the problem.
It is not a problem, because the code works well and it is not visible to the user. It can be considered a 'code smell' by some devs.

Describe the solution you'd like to see.
Removed duplication of code 😄

Were you inspired by anything else, that you have experienced?
Inspired by @YonatanKra

Describe alternatives you've considered (if any). If you haven't that is also ok 😄
The alternative is leaving the duplicated code, but as new people contribute this will become more and more problematic.

Any additional details about this request that you want to share?
Nope

How important is it for you to have this feature?
It could save time in the future because if there is only one implementation, changes will be made in one place instead of 3.
@dastin-sandura dastin-sandura added the enhancement New feature or request label Oct 30, 2020
@dastin-sandura dastin-sandura mentioned this issue Oct 30, 2020
Merged
@dastin-sandura dastin-sandura changed the title Refactor: extract common logic for checking if a reserved keyword is used in from let, const and assign to avoid code duplication Refactor: extract common logic, checking if a reserved keyword is used, from let, const and assign resources to avoid code duplication. Oct 31, 2020
@dastin-sandura
Copy link
Contributor Author

I shall hug this issue

@dastin-sandura dastin-sandura linked a pull request Nov 4, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@dastin-sandura