Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kapowarr doesn't remove zip-file and .extract_achive folder after extracting #226

Open
gerrewsb opened this issue Jan 7, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@gerrewsb
Copy link

gerrewsb commented Jan 7, 2025

Description of the bug
When downloading and importing a multi-issue zip-file the issues are unzipped correctly but then Kapowarr crashes. Not deleting the zip-file or the .archive_extract folder.

To Reproduce
Download a volume that consists of multiple zipfiles with multiple issues (for example The Flash Volume 5).
During the importing stage it will stall. no errors in the frontend.

Expected behaviour
Extract the issues and remove the zipfile and extraction folder

Screenshots
image

image

Version info
Running in docker
image

Additional context
Error log:

[15:52:38][DEBUG] Renaming file /comics-1/The Flash/The Flash (2016) Volume 5/The Flash 043 (2018) (2 covers) (digital) (Minutemen-Thoth).cbz to /comics-1/The Flash/The Flash (2016) Volume 5/The Flash (2016) Issue 043 - Perfect Storm Part Five.cbz
[15:52:38][DEBUG] Deleting folders from /comics-1/The Flash/The Flash (2016) Volume 5 until /comics-1/The Flash
[15:52:38][DEBUG] Closing connection <DBConnection; Download Handler; 140119419852720>
Exception in thread Download Handler:
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/usr/local/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/app/backend/download_queue.py", line 124, in __run_download
    PostProcesser.success(download)
  File "/app/backend/post_processing.py", line 236, in success
    cls._run_actions(cls.actions_success, download)
  File "/app/backend/post_processing.py", line 230, in _run_actions
    action(download)
  File "/app/backend/post_processing.py", line 117, in convert_file
    mass_convert(
  File "/app/backend/conversion.py", line 243, in mass_convert
    resulting_files = converter.convert(f)
  File "/app/backend/converters.py", line 253, in convert
    resulting_files = mass_rename(
  File "/app/backend/naming.py", line 710, in mass_rename
    cursor.executemany(
sqlite3.IntegrityError: UNIQUE constraint failed: files.filepath
@gerrewsb gerrewsb added the bug Something isn't working label Jan 7, 2025
@gerrewsb
Copy link
Author

gerrewsb commented Jan 7, 2025

I THINK i know the cause for this one. I removed a bunch of issues because it didn't download everything. i removed them in the folder but didn't rescan in kapowarr so that's probably why it complains about a unique constraint of the filepath.

anyway, another issue with this volume: it doesn't download issue 1-14 and 750-785. But there are links for it on the download page of GetComics.

image

image

nothing in Kapowarr's blocklist about these links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant