Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatability] with ModelReplacementAPI #13

Closed
1 task done
BunyaPineTree opened this issue Apr 1, 2024 · 1 comment
Closed
1 task done

[Compatability] with ModelReplacementAPI #13

BunyaPineTree opened this issue Apr 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@BunyaPineTree
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the feature

Hello, this is the ModelReplacementAPI developer.
I was testing an upcoming first person viewmodel feature on mods like Lethal Phones when I realized an issue that doesn't have an immediate solution.

image
This is selecting the 3, and is one of the better examples

Because my mod works by copying rotations, but not positions to prevent model warp, models with different proportions inevitably result in situations like this where it is difficult or impossible to use the phone dial feature.

A potential solution to this issue would be having an optional cursor, or red circle, or whatnot that indicates where you are aiming.

I have reviewed the source code of your mod, and given the complexity of PlayerPhone.ManageInputs() I don't think I would be able to patch this myself, but if you implemented the toggleable cursor I could manage the activation and deactivation of that cursor on my end when it's necessary.

@BunyaPineTree BunyaPineTree added the enhancement New feature or request label Apr 1, 2024
@CassCoffey
Copy link
Owner

This should hopefully be fixed with the new config option added in this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants