Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open TODOs in TransactionBuilder.ts #238

Open
mr-zwets opened this issue Nov 7, 2024 · 0 comments
Open

Open TODOs in TransactionBuilder.ts #238

mr-zwets opened this issue Nov 7, 2024 · 0 comments
Labels
javascript-sdk Relates to the CashScript JavaScript SDK

Comments

@mr-zwets
Copy link
Member

mr-zwets commented Nov 7, 2024

There's 3 open TODOs in TransactionBuilder.ts which have been there since more than a year (13 months atm)

  // TODO: allow uint8array for chunks
  addOpReturnOutput(chunks: string[]): this {
  ...

// TODO: see if we can merge with Transaction.ts
  async send(): Promise<TransactionDetails>;

  // TODO: see if we can merge with Transaction.ts
  private async getTxDetails(txid: string): Promise<TransactionDetails>;
@mr-zwets mr-zwets added the javascript-sdk Relates to the CashScript JavaScript SDK label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript-sdk Relates to the CashScript JavaScript SDK
Projects
None yet
Development

No branches or pull requests

1 participant