Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullStackNetworkProvider failing P2SH32 tests #231

Open
mr-zwets opened this issue Oct 29, 2024 · 5 comments
Open

FullStackNetworkProvider failing P2SH32 tests #231

mr-zwets opened this issue Oct 29, 2024 · 5 comments
Labels
javascript-sdk Relates to the CashScript JavaScript SDK

Comments

@mr-zwets
Copy link
Member

mr-zwets commented Oct 29, 2024

Currently the FullStackNetworkProvider tests are skipped because they fail...

describe.skip('P2PKH (using FullStackNetworkProvider)', () => {
  let p2pkhInstance: Contract;

We get an error when calling .send()

Object {
      "error": Object {
        "error": "Invalid Argument: Must provide a `hash` or `hashBuffer` property",
        "success": false,
      },
      "success": false,
    }

```

it seems the `await bchjs.Electrumx.utxo()` somehow does not support P2SH32 like
`bitcoincash:pdpjeyus929guj00y3sz3ec8ehd2v73e4art9v7prsvke5yujvt5vs6mz82xa`

We tested this with upgrading to the latest is `6.8.0` before we were still at `"@psf/bch-js": "^4.15.0"
@mr-zwets mr-zwets added the javascript-sdk Relates to the CashScript JavaScript SDK label Oct 29, 2024
@mr-zwets
Copy link
Member Author

@christroutner do you know why we're getting this error?

@christroutner
Copy link

FullStack is still running Fulcrum v1.2.3 which is quite old at this point and does not include updates for CashTokens or BitInts. I'm in the process of updating it and will update this issue when it is complete. We'll see if that solves the issue.

@christroutner
Copy link

I just updated FullStack.cash to the latest version of Fulcrum. @mr-zwets go ahead and try again. Let me know if you still see the issue or not.

@mr-zwets mr-zwets changed the title update / remove FullStackNetworkProvider (failing tests) FullStackNetworkProvider failing P2SH32 tests Nov 9, 2024
@mr-zwets
Copy link
Member Author

mr-zwets commented Nov 9, 2024

@christroutner discovered the issue was not with the version of fulcrum but with the addressToScripthash function of the fulcrum REST-api

I opened an issue for P2SH32 support on the fulcrum-api repo with a suggested solution 😄 👍
Permissionless-Software-Foundation/fulcrum-api#13

@christroutner
Copy link

Continuing this conversation there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript-sdk Relates to the CashScript JavaScript SDK
Projects
None yet
Development

No branches or pull requests

2 participants