Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config bug? #44

Open
Jaderey opened this issue Nov 1, 2024 · 5 comments
Open

Config bug? #44

Jaderey opened this issue Nov 1, 2024 · 5 comments

Comments

@Jaderey
Copy link

Jaderey commented Nov 1, 2024

some configs don't show up in CarbonConfig where they do show up in Configured. my example being the mod Spore having two configs that show up under Configured the two configs being Sporeconfig.toml and Sporedata.toml.

Only Sporeconfig.toml shows up under CarbonConfig. i do not have an error log for this though.

@Speiger
Copy link
Contributor

Speiger commented Nov 1, 2024

@Jaderey could you link the mod in question?

@Jaderey
Copy link
Author

Jaderey commented Nov 1, 2024

https://www.curseforge.com/minecraft/mc-mods/fungal-infection-spore
i'm using spore_1.20.1_2.1.1

@Speiger
Copy link
Contributor

Speiger commented Nov 1, 2024

@Jaderey most likely because you don't have a world present where you can open the gui from.

@Jaderey
Copy link
Author

Jaderey commented Nov 3, 2024

@Speiger Not sure i understand what you mean. Not sure why it works with plain old Configured if that were the case. i was just worried that if it didint show a config for 1 mod what other mods configs might it miss?

@Speiger
Copy link
Contributor

Speiger commented Nov 3, 2024

@Jaderey ok i finally understood what you problem is.

I know why only 1 config shows up.
The mod kinda hacks in a second config since forge technically doesn't support multiple config files per type.
(There is client => not loaded on servers, Common => loaded on both, Server => Only loaded on servers)

And the mod is doing that.
Why it works in Configured and not CarbonConfig.
Configured uses a different way to scan for configs. It scans over all config files and remaps them to the respective mods.
I scan for mods, and fetch their Configs, which forge only stores 1 per type.

Configureds way supports duplicates, CarbonConfigs doesn't.

Not sure If i deem it a bug or not. I have to think about that. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants