Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util.lua fails to understand certain comments in VMTs, then dumps entire VMT to console #1389

Open
TiberiumFusion opened this issue Dec 9, 2024 · 0 comments

Comments

@TiberiumFusion
Copy link

PAC3 fails to understand some comment lines in VMT files, despite the VMT being potentially valid and having no errors whatsoever. When this happens, it dumps the entire VMT to the console.

If this dump also occurs for non-local players, then this needlessly leaks part of your outfit to the other players. Given the officially unofficial stance of "don't expose my outfit's sources to the other players", this seems like something that should be fixed.

Demo

  1. New outfit.
  2. Add a model2 part.
  3. Set url to this minimal test model:
    demo_teapot.zip
  4. Wait for download to finish.
  5. Observe console:
[PAC3] vmt mat_teapot.vmt wants to find texture materials/directive relative to other lines in the vmt file actually can change things.vtf for $lightwarptexture but it doesn't exist
vertexlitgeneric
{
	$basetexture "vgui/white"
		//$color "{255 255 255}" // customize color
		// ^ pac properly handles this comment line
	
	$lightwarptexture "models/player/pyro/pyro_lightwarp"
		// the location of the $lightwarptexture directive relative to other lines in the vmt file actually can change things
		// ^ pac fucks up on this comment line and dumps this entire vmt to the console
}

Refer to the VMT inside the provided .zip, as shown dumped in full to the console.

Version: 67ba3954d04bc7c992f2054505a7e8d178578cb4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant