Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script to backup logs #369

Closed
wants to merge 12 commits into from
Closed

script to backup logs #369

wants to merge 12 commits into from

Conversation

ayusham001
Copy link
Contributor

/claim #367

@netlify
Copy link

netlify bot commented Sep 17, 2023

Deploy Preview for webcapgo ready!

Name Link
🔨 Latest commit c278ec5
🔍 Latest deploy log https://app.netlify.com/sites/webcapgo/deploys/65150bf5e3ec2b000887fbde
😎 Deploy Preview https://deploy-preview-369--webcapgo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 78 (🔴 down 6 from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 85 (no change from production)
PWA: 100 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2023

🤖 ChatGPT score: Based on the provided diff, I would score the pull request with a 90. The script adds functionality to backup and delete entries from specific tables in a Supabase database based on a cutoff date. The code appears well-structured and handles potential errors.

Copy link
Contributor

@rishi-raj-jain rishi-raj-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayusham001
Copy link
Contributor Author

Hi @rishi-raj-jain and @akhill10, I have made the necessary changes. Please take a look at it.

@rishi-raj-jain
Copy link
Contributor

@ayusham001 can you resolve the comments from above you think are done? I still see some of them are not resolved after your latest commit.

@ayusham001
Copy link
Contributor Author

@ayusham001 can you resolve the comments from above you think are done? I still see some of them are not resolved after your latest commit.

Which one are you talking about? I made some changes in the recent one

@rishi-raj-jain
Copy link
Contributor

Here are the summary of changes that I think are still pending:

Screenshot 2023-09-18 at 1 31 50 PM
Screenshot 2023-09-18 at 1 33 56 PM
Screenshot 2023-09-18 at 1 34 12 PM

@akhill10
Copy link

@rishi-raj-jain It looks like you haven't submitted your review as it still shows pending in you're screenshots.

@ayusham001
Copy link
Contributor Author

Here are the summary of changes that I think are still pending:

Screenshot 2023-09-18 at 1 31 50 PM Screenshot 2023-09-18 at 1 33 56 PM Screenshot 2023-09-18 at 1 34 12 PM

@rishi-raj-jain I guess you haven't submitted the review
because it's not showing here.

supabase/functions/_script/backup_and_cleanup.ts Outdated Show resolved Hide resolved
supabase/functions/_script/backup_and_cleanup.ts Outdated Show resolved Hide resolved
supabase/functions/_script/backup_and_cleanup.ts Outdated Show resolved Hide resolved
supabase/functions/_script/backup_and_cleanup.ts Outdated Show resolved Hide resolved
supabase/functions/_script/backup_and_cleanup.ts Outdated Show resolved Hide resolved
supabase/functions/_script/backup_and_cleanup.ts Outdated Show resolved Hide resolved
supabase/functions/_script/backup_and_cleanup.ts Outdated Show resolved Hide resolved
supabase/functions/_script/backup_and_cleanup.ts Outdated Show resolved Hide resolved
supabase/functions/_script/backup_and_cleanup.ts Outdated Show resolved Hide resolved
@rishi-raj-jain
Copy link
Contributor

@ayusham001 I've submitted my review now. Thanks for informing!

@ayusham001
Copy link
Contributor Author

ayusham001 commented Sep 18, 2023

@rishi-raj-jain I have made the changes, Please have a look at it.

@ayusham001
Copy link
Contributor Author

Hi @riderx, I have made the changes that have been suggested
please have a look at it.

@rishi-raj-jain
Copy link
Contributor

@ayusham001 taking a look right now

@riderx
Copy link
Contributor

riderx commented Sep 19, 2023

@ayusham001 did you evaluate to do it in SQL directly ? I'm afraid to bloat the db with the loop query that way

@rishi-raj-jain
Copy link
Contributor

rishi-raj-jain commented Sep 19, 2023

I've left a comment to be addressed ^^

Do confirm if you see it.

@ayusham001
Copy link
Contributor Author

@rishi-raj-jain please have a look at it:)

@ayusham001
Copy link
Contributor Author

ayusham001 commented Sep 19, 2023

@riderx I have used SQL query instead of Supabase SDK in my recent commit.
Please review it:)

@akhill10
Copy link

akhill10 commented Sep 19, 2023

@ayusham001 did you evaluate to do it in SQL directly ? I'm afraid to bloat the db with the loop query that way

I think @riderx was pointing out that, instead of using supabase SDK. Create a SQL function in postgres db that executes this logic directly maybe with the help of storage extensions.

@rishi-raj-jain
Copy link
Contributor

I think @riderx was pointing out that, instead of using supabase SDK. Create a SQL function in postgres db that executes this logic directly maybe with the help of storage extensions.

How is this different from using Supabase SQL rpc?

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rishi-raj-jain
Copy link
Contributor

LGTM

@riderx riderx closed this Sep 29, 2023
@ayusham001 ayusham001 deleted the 367 branch September 30, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants